Comments (5)
This is already tracked for Alice in #131
from xmr-btc-swap.
This is already tracked for Alice in #131
I disagree. #131 only touches the ASB (automated swap backend) and is not concerned about the CLI.
Additionally #131 only states does not proceed with swap execution if predicted Bitcoin quantity to sell is above a configurable ratio of total balance.
which is a different problem.
The problem I am describing is ensuring that either party has enough funds to proceed with locking. Especially on the ASB (automated swap backend) side this is critical for UX, because if Alice does not have the funds to find after Bob does then Bob might fund without her being able to proceed.
This goes towards the previous strategy of Nectar to do some bookkeeping to ensure funds are available. We don't have to do that right away but should keep it in mind.
Concerning the CLI, there should be a better error message when Bob has insufficient funds. Note that the behavor will depend on the decisions taken in #193
from xmr-btc-swap.
- CLI should immediately exit if not enough balance.
- ASB should send error for quote request if not enough balance.
- CLI should exit if error from quote request.
from xmr-btc-swap.
The swap-cli handles this now with #236 by waiting for funds on startup if the balance is 0.
from xmr-btc-swap.
I think both parties now have balance checks.
from xmr-btc-swap.
Related Issues (20)
- make a help guide for swappers HOT 3
- `asb` wallet inaccessible after refreshing it with `monero-wallet-cli` HOT 21
- upgrade to monero 0.18.2.0
- Reporting a vulnerability HOT 3
- unstoppableswap monero not issuing cannot issue refund. HOT 2
- switch from bors to github merge queue
- How to properly use Adaptor Signatures
- Can't swap: can't `list-sellers` because local peer doesn't support protocols requested by remote HOT 12
- BCH-XMR Swap HOT 1
- Issues with syncing the Bitcoin wallet
- Issues with redeeming the Monero HOT 8
- cross build broken HOT 2
- GUI is stuck on redeeming Monero. HOT 1
- [0.5 XMR] Failed to broadcast Bitcoin redeem transaction: mempool min fee not met HOT 2
- My btc-xmr swap with provider has been stuck on "Locking BTC" step for 10 hours now, yet to be confirmed HOT 8
- Use `libtor` to bundle tor directly into the CLI HOT 3
- Display Monero wallet sync progress
- Build error[E0282]: type annotations needed HOT 5
- No swap providers in registry as of 12/9/23 in Windows UnstoppableSwap v0.5.2 app HOT 1
- fix warnings in build binaries CI
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from xmr-btc-swap.