Giter VIP home page Giter VIP logo

Comments (5)

D4nte avatar D4nte commented on June 15, 2024

This is already tracked for Alice in #131

from xmr-btc-swap.

da-kami avatar da-kami commented on June 15, 2024

This is already tracked for Alice in #131

I disagree. #131 only touches the ASB (automated swap backend) and is not concerned about the CLI.

Additionally #131 only states does not proceed with swap execution if predicted Bitcoin quantity to sell is above a configurable ratio of total balance. which is a different problem.

The problem I am describing is ensuring that either party has enough funds to proceed with locking. Especially on the ASB (automated swap backend) side this is critical for UX, because if Alice does not have the funds to find after Bob does then Bob might fund without her being able to proceed.
This goes towards the previous strategy of Nectar to do some bookkeeping to ensure funds are available. We don't have to do that right away but should keep it in mind.

Concerning the CLI, there should be a better error message when Bob has insufficient funds. Note that the behavor will depend on the decisions taken in #193

from xmr-btc-swap.

thomaseizinger avatar thomaseizinger commented on June 15, 2024
  1. CLI should immediately exit if not enough balance.
  2. ASB should send error for quote request if not enough balance.
  3. CLI should exit if error from quote request.

from xmr-btc-swap.

thomaseizinger avatar thomaseizinger commented on June 15, 2024

The swap-cli handles this now with #236 by waiting for funds on startup if the balance is 0.

from xmr-btc-swap.

thomaseizinger avatar thomaseizinger commented on June 15, 2024

I think both parties now have balance checks.

from xmr-btc-swap.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.