Comma 2.1.1 not working with Rails 2.3.15? about comma HOT 8 CLOSED

Hi @stigmh , thanks for the report! Trying not to support Rails 2, but I'll have a look now.

Cheers,

Tom

from comma.

Hi, the code in render_as_csv should work, its odd if its in the wrong area.

Are you using bundle exec and using the correct version of comma? did you uninstall and remove the old version (for a test).

from comma.

Oh wait, found the error. Will fix now :)

from comma.

Ok, I unfortunately don't have a rails 2 app to hand to check, and the specs aren't written for testing a dummy rails 2 app, could you please do me a favor and test these fixes in your app?

Simply update your Gemfile to :

gem 'comma', '2.1.1', :git => 'http://github.com/crafterm/comma.git', :branch => 'fix-rails2', :ref => 'b860df5c'

and see if that resolves the issue, I think that should be fine then for future rails point releases (in the 2.3.x area).

Cheers,

Tom

from comma.

Yes, to both your first questions. I will test it later to day (4-6 hours), I'm currently not nearby a machine with capability to test it. I'll let you know once it's done. Thanks!

from comma.

Hi, I can confrim that it works! Currently running on a 2.3.15 production app. Thanks for the quick fix! :D

from comma.

No problem, I'll make a release later today.

On 06/02/2013, at 6:23 AM, "Stig M. Halvorsen" [email protected] wrote:

Hi, it works! Thanks for the quick fix! :D

—
Reply to this email directly or view it on GitHub.

from comma.

Fixed and deployed : version 2.1.2

Thanks again for the bug report.

Cheers,
Tom

from comma.