Giter VIP home page Giter VIP logo

Comments (4)

Ashoat avatar Ashoat commented on May 30, 2024

#57 is almost done!

Five follow-ups from there:

  • Include unread count in background tab title
  • Since background tab will initially be empty, let's show some explanatory message when there are no background threads
  • Let's rename the setting from "Home notifs" to "Background" and invert the value
  • Update the unread counts to not consider background thread
  • Web support

from comm.

Ashoat avatar Ashoat commented on May 30, 2024

RE 4 above, for some reason I thought this was already done, but it isn't.

There are client-side and server-side places that need to be fixed up.

From client side: there is an unreadCount selector in lib right now. Until we do 5 above, we should keep web using the old unreadCount that includes background threads, but create a new one for native to use that doesn't count background threads. We'll need to make sure all places in native that use unreadCount get updated to use the new one.

As for the server side, there are two SQL queries that fetch unread count, both in server/src/push. One is a query specifically to fetch unreadCounts, called getUnreadCounts, in server/src/push/utils.js. The other is a query to rescind notifs in server/src/push/rescind.js.

from comm.

Ashoat avatar Ashoat commented on May 30, 2024

All that's left now is web support!

from comm.

Ashoat avatar Ashoat commented on May 30, 2024

@KatPo reminded me over chat that she still needs to finish #100. Feel free to reopen the issue next time!

from comm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.