WorkflowWidgetStep "Finish" button about ctk HOT 6 OPEN

This is not a bug, but is how the finish button is implemented. Let's say that you are in step 4 of 6 steps. The idea is that, if you press the finish button at step 4, you can see what the result would be using the default parameters for steps 5 and 6. Then, you can easily go on to customize steps 5 and 6 if you want.

Dumping you to step 6 at the end would help emphasize that the execution was made all the way to the finish step, but doesn't let you further customize unless you hit "back" a few times. But, dumping you to the last step would be more in line with how other wizards (ex. installers) behave.

However, you are not the first person to be confused by this behavior, and JC and I are thinking of ways to either make this behavior more intuitive, or to change the code such that the finish step's page is displayed at the end.

To the group:
Would it be more intuitive to you if we changed the "finish" button to say "preview" instead, keeping the current behavior? Or would you rather the finish step UI still be displayed?

from ctk.

FYI, Daniel has added the property in ctkWorkflow called "GoBackToOriginStepUponSuccess", with a default value of true. If you set this property to false for your workflow, you should see the finish step at the end.

So, we can debate whether the default property value should be true or false, but both implementations are there.

from ctk.

My vote is that it should not be the default (to go back to the origin step upon success)

from ctk.

Thanks for the information! This property would be fine, and I vote also for being false as default.

The bigger problem, however, is that the property does not work for me. It was true, as you said, and I set it to false in the constructor of the workflow, but I still see the original page when the computation finishes.

from ctk.

This GoBackToOriginStepUponSuccess property is rather buggy.

The "Finish" button executes the workflow steps. If GoBackToOriginStepUponSuccess is set to false then the current workflow step will be the last executed step, but the WorkflowStackedWidget still displays the original step.

This has a strange consequence: You cannot press the Next button, since you are at the last step, although the GUI shows that you are at the beginning step. If you press the Back button, then you get to the last but one step, and the GUI will show the same.

However, if you pressed the Finish button at the first step, then cannot press the Back button, since it is disabled.

from ctk.

cim-unito@08d9f88

It also contains other trivial fixes. I did not change the default value of the GoBackToOriginStepUponSuccess property, since I can fix it from my program, but it should be done in my opinion.

Now if the flag is on (still default), the Finish button performs the workflow steps, the actual page appears after entering into the individual steps, and after finishing the original page reappears. Until now the original page was visible during the whole process. If you want this, put the "emit q->currentStepChanged(this->CurrentStep);" line in an if (!GoBackToOriginStepUponSuccess) around line 418.

from ctk.