Use get_historical_evidence helper in checks about auditree-arboretum HOT 3 CLOSED

"get_historical_evidence" functionality currently in PR ComplianceAsCode/auditree-framework#71

from auditree-arboretum.

I wonder if we do this, we shouldn't also add a helper method like self.get_last_evidence() instead of self.locker.get_evidence?

from auditree-arboretum.

I think a self.get_last_evidence() would be redundant to the with_raw_evidences decorator and the evidences context manager. Using either of those ensures we perform a TTL validation and that the evidence gets stored as part of the report metadata. We don't have something comparable for historical evidence so we've been using self.locker.get_evidence in checks that need historical evidence. The problem there is that it doesn't store the evidence in the reports metadata. Adding get_historical_evidence to the check remedies that. I could have updated with_raw_evidences and evidences to handle historical evidence but I thought that this was the less disruptive change.

from auditree-arboretum.