Giter VIP home page Giter VIP logo

Comments (2)

jflatow avatar jflatow commented on July 28, 2024

We removed occurrences of implicit upscaling. We accept that uint256 and uint are interchangeable in Solidity and that authors are aware of this. In #454 we go even further, and also attempt to eliminate an unsafe cast which came up in the ChainSecurity audit but which we chose to keep as a gas optimization. We will leave this open until these changes have had further review (and until that PR is merged).

from comet.

jflatow avatar jflatow commented on July 28, 2024

The changes have been reviewed by ourselves, OZ and ChainSecurity and we've merged the PR, closing.

from comet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.