Giter VIP home page Giter VIP logo

Comments (6)

GabrielDierks avatar GabrielDierks commented on July 4, 2024 1

I can confirm it is working on 2.0.6! But I have the same issue with 2.0.7

The issue seems to be caused by this function:

if (open) { [...itemRefs.current.entries()].forEach(([id, ref]) => { if (id !== item.id && ref) ref.close(); });

from react-native-swipeable-item.

joshbuddy avatar joshbuddy commented on July 4, 2024

Did a little more testing and this is a regression in 2.0.7, 2.0.6 works correctly.

from react-native-swipeable-item.

computerjazz avatar computerjazz commented on July 4, 2024

So, there are two things going on there, both should be fixed in 2.0.8 --

  • I named the open parameter in onChange poorly as it is an enum. It is now renamed to openDirection. It shouldn't be checked for truthiness since it is always a string value.
  • onChange was being called too often.

https://github.com/computerjazz/react-native-swipeable-item/releases/tag/v2.0.8

from react-native-swipeable-item.

joshbuddy avatar joshbuddy commented on July 4, 2024

Thank you so much. Everything works great with 2.0.8.

from react-native-swipeable-item.

jmif avatar jmif commented on July 4, 2024

We're seeing this in 2.0.8 still, the app becomes progressively slower especially after swiping. We ended up rolling back to 2.0.6 and the issue was resolved. I've confirmed that we're properly checking open and that onChange is not being called frequently in 2.0.8. We're on reanimated 2.9.1.

from react-native-swipeable-item.

computerjazz avatar computerjazz commented on July 4, 2024

@jmif If you can provide a repro via an expo snack I'll take a look.

from react-native-swipeable-item.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.