Giter VIP home page Giter VIP logo

Comments (15)

samwar avatar samwar commented on July 17, 2024 3

I've started to look at the diff and port over the changes in a new fork. Hopefully I'll have this done in the next couple of weeks.

from mongodb-erlang.

yangcancai avatar yangcancai commented on July 17, 2024

1

from mongodb-erlang.

kjellwinblad avatar kjellwinblad commented on July 17, 2024

Support for MongoDB 5.1+ has been added to this fork https://github.com/emqx/mongodb-erlang (MongoDB 5.1 was the first version that removed support for the legacy opcodes).

Unfortunately, it is not easy to merge this change back as EMQX's fork and this repository has diverged quite a lot. EMQX has worked on their own fork since they want to maintain hot-upgradability. I think EMQX would appreciate if someone has time/interest to merge back changes from EMQX's fork to this repository.

from mongodb-erlang.

codeadict avatar codeadict commented on July 17, 2024

That's awesome @kjellwinblad , i've been checking the changes and they look great. I can volunteer to merge changes back but depends on what the maintainers think about integrating all the changes the emqx fork have or only a subset of them. Thoughts @comtihon ?

from mongodb-erlang.

GabrielSchlatter avatar GabrielSchlatter commented on July 17, 2024

1

from mongodb-erlang.

ioolkos avatar ioolkos commented on July 17, 2024

+1 @comtihon can you comment on @codeadict's suggestion?

from mongodb-erlang.

comtihon avatar comtihon commented on July 17, 2024

that would be great, unfortunately I don't have time to do it myself.

from mongodb-erlang.

ioolkos avatar ioolkos commented on July 17, 2024

@comtihon Great, thanks for your feedback! :)
@kjellwinblad, @codeadict let's see how to best organise this merge back.

from mongodb-erlang.

samwar avatar samwar commented on July 17, 2024

@codeadict Any updates to provide on the progress?

from mongodb-erlang.

samwar avatar samwar commented on July 17, 2024

@kjellwinblad @codeadict Any word on the changes?

If you touched a specific set of merges or modules when making the changes to support Mongo 5.1+, we could collectively backport the changes or make another fork.

from mongodb-erlang.

kjellwinblad avatar kjellwinblad commented on July 17, 2024

@kjellwinblad @codeadict Any word on the changes?

If you touched a specific set of merges or modules when making the changes to support Mongo 5.1+, we could collectively backport the changes or make another fork.

Not sure what you mean with "touched a specific set of merges or modules". When I started the work to support 5.1+ in https://github.com/emqx/mongodb-erlang, the repositories had already diverged quite a bit so a merge is not straightforward. One option could be to let development continue in our (EMQX's) repository and that eventual missing features/fixes in EMQX's repository is ported from this repository. Maybe this direction is easier?

Also it might be worth mentioned that we have noticed that the current driver seems to be quite inefficient (a lot of message passing going back and forth different processes only to do a singe insert) so it might be worth it to start with a blank slate and create a new more efficient driver that only supports the new protocol.

from mongodb-erlang.

GabrielSchlatter avatar GabrielSchlatter commented on July 17, 2024

We received notifications from MongoDB Atlas recently: "MongoDB 5.0 End of Life on October 31, 2024; automatic Atlas cluster upgrades to 6.0". Is there any chance the driver will be updated and made compatible before that date?

from mongodb-erlang.

comtihon avatar comtihon commented on July 17, 2024

Unfortunately I don't have time for it RN. So either someone can propose a PR or I will try to find the time for it till Oct.

from mongodb-erlang.

samwar avatar samwar commented on July 17, 2024

@kjellwinblad @codeadict Any word on the changes?
If you touched a specific set of merges or modules when making the changes to support Mongo 5.1+, we could collectively backport the changes or make another fork.

Not sure what you mean with "touched a specific set of merges or modules". When I started the work to support 5.1+ in https://github.com/emqx/mongodb-erlang, the repositories had already diverged quite a bit so a merge is not straightforward. One option could be to let development continue in our (EMQX's) repository and that eventual missing features/fixes in EMQX's repository is ported from this repository. Maybe this direction is easier?

Also it might be worth mentioned that we have noticed that the current driver seems to be quite inefficient (a lot of message passing going back and forth different processes only to do a singe insert) so it might be worth it to start with a blank slate and create a new more efficient driver that only supports the new protocol.

If the drivers have diverged so much, it might not be straightforward for those of us using the OG (this) MongoDB driver to switch to using your fork. If there are still some similarities, I was hoping the changes in your driver could be picked out. If you can pinpoint a range of commits and modules where you added support for Mongo 5.1+, then it would be easier to attempt to port the changes to this driver.

It may be as easy as porting these two commits into this driver.
37a2254
c2bf978
9ea3196

from mongodb-erlang.

ioolkos avatar ioolkos commented on July 17, 2024

@samwar do you think porting over the changes is feasible or ETOOCOMPLEX? just interested in your assesment, no "impatience" at all.
I think projects depending on mongodb-erlang can switch to the emqx fork in any case, but I also still think bundling forces on 1 fork is the most sustainable approach for the driver.
@codeadict @kjellwinblad @GabrielSchlatter

from mongodb-erlang.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.