Giter VIP home page Giter VIP logo

Comments (16)

jakirkham avatar jakirkham commented on June 12, 2024 1

Was trying to think of names that fit with the forge theme (I like the creative spark and wanted to keep it alive). We could call it linux-anvil. Just thinking of how the anvil is used as a base while some metal is being worked. If we want to add architecture, we can do that too. Just a thought.

from docker-images.

pelson avatar pelson commented on June 12, 2024 1

🔨 Love it. ❤️

Let's not include the arch - we can always add another image with a x86 suffix if needs be.

from docker-images.

jakirkham avatar jakirkham commented on June 12, 2024

@pelson, do you have a favored name?

from docker-images.

pelson avatar pelson commented on June 12, 2024

Not really. There are many running through my head (linux, linux-build, conda-build, linux-64) but none that really grab me. You?

from docker-images.

jakirkham avatar jakirkham commented on June 12, 2024

I was going to say no (honestly was thing image for a bit 😆), but this one might not be too bad.

centos_devtoolset-2_64:6

Has the OS name, explains the compiler config, mentions 64-bit only is supported, and is versioned the same way the centos image is. Not the most creative name, but it explains what it is without being too long (I hope).

Thoughts?

from docker-images.

pelson avatar pelson commented on June 12, 2024

The only concern is the fact that a lot of implementation detail exists in the name (a bad thing rather than a good thing for me, as it means that as we change the detail, we also need to change the name).

from docker-images.

jakirkham avatar jakirkham commented on June 12, 2024

...a bad thing rather than a good thing for me...

I guess I had the opposite view.

In any event, I'm not really picky on the image name, which is why I was happy to let you pick one and still am. 😄

from docker-images.

pelson avatar pelson commented on June 12, 2024

So if we don't want implementation detail in the name:

linux-build-x86_64

from docker-images.

jakirkham avatar jakirkham commented on June 12, 2024

Just as a question, if we do ever support 32-bit, would you prefer it in a separate image or the same one?

from docker-images.

pelson avatar pelson commented on June 12, 2024

if we do ever support 32-bit, would you prefer it in a separate image or the same one?

A question I was asking myself earlier on. In the obvious-ci image I went for "the same one". In the name proposed above I went for "a different image".

from docker-images.

jakirkham avatar jakirkham commented on June 12, 2024

Could you help me understand why you want to keep them separate? I could certainly see some arguments for it, but would like to here your thoughts on it.

Something to consider (not that this is completely tied to this nor that this rules out having separate images either), we could select the architecture through other means. Though we may want this option in such a configuration tool no matter what we do here.

from docker-images.

pelson avatar pelson commented on June 12, 2024

Could you help me understand why you want to keep them separate?

This is simply a historically driven argument, whereby an entirely 32-bit docker image was used to produce linux-32 builds. I imagine there is detail in managing 32bit builds which would need to be handled if we were doing them on a 64bit machine (like the conda subdir / platform).

I'm guessing you are asking because you do believe that we can use the same image to produce both x86 and x64 builds?

from docker-images.

jakirkham avatar jakirkham commented on June 12, 2024

This is simply a historically driven argument...

Ah ok. Precedent mainly.

I'm guessing you are asking because you do believe that we can use the same image to produce both x86 and x64 builds?

We could. That's what I did with the example image. Not saying we should or shouldn't here. Just as long as we are aware of the option.

from docker-images.

jakirkham avatar jakirkham commented on June 12, 2024

Glad you like it. 😄

Let's not include the arch - we can always add another image with a x86 suffix if needs be.

Sure. Increasingly it seems 32-bit is an oddity in the Linux world. So noting it is different seems ok to me.

Will make the changes now.

from docker-images.

jakirkham avatar jakirkham commented on June 12, 2024

Here's the PR ( #9 ) for the rename.

from docker-images.

jakirkham avatar jakirkham commented on June 12, 2024

Updated the PRs to staged-recipes ( conda-forge/staged-recipes#514 ) and conda-smithy ( conda-forge/conda-smithy#151 ) to reflect the name change.

from docker-images.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.