ZooKeeper configuration should have reasonable defaults about cp-docker-images HOT 6 CLOSED

@cotedm 2000 is ZK's internal default too. So, that works out :)

from cp-docker-images.

I tried to match the required properties and these are required as per the ZK docs[1]. But I agree with you that these are advanced configs and we should add defaults for these (to match CP defaults).

[1] http://zookeeper.apache.org/doc/r3.4.6/zookeeperAdmin.html#sc_minimumConfiguration

from cp-docker-images.

cool, I'll update the docs during my review now since it sounds like you'll be making this change. PR will be incoming :)

from cp-docker-images.

Update: Looks like ZK docs are incorrect and tickTime is set to a default value of 2000 if not set. So, I will make that optional.

But, syncLimit and initLimit are not optional [2]. Need to figure out if there are any sensible defaults for these.

[2] https://github.com/apache/zookeeper/blob/branch-3.4/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java#L310-L315

from cp-docker-images.

As per @cotedm suggestion, we will use cloudera's defaults for syncLimit and initLimit.

# The number of ticks that the initial 
# synchronization phase can take
initLimit=10
# The number of ticks that can pass between 
# sending a request and getting an acknowledgement
syncLimit=5

from cp-docker-images.

@arrawatia may want to consider adjusting tickTime to the 2000 default in CDH too since those defaults you've mentioned depend on that

from cp-docker-images.