java.lang.ArithmeticException when using 0 about barapi HOT 10 CLOSED

Why would you pass 0? Use setMessage(Player player, String message) instead if you don't need a timer.

from barapi.

If a player joins my game just before it starts (less than 1 second remaining) this exception is thrown.
And i don't want to write a workaround for this case.
It would be great to have at least javadoc documenting this beahaviour.

from barapi.

Then can you not add a check within your code for this scenario? I don't
really believe its the job of the API to handle incorrect arguments to it
as far as seconds go. The problem is, I would need to throw some form of an
exception if 0 or less is passed so you would still encounter an error in
the console unless it is caught regardless.

On Sun, Dec 29, 2013 at 1:37 PM, ST-DDT [email protected] wrote:

If a player joins my game just before it starts (less than 1 second
remaining) this exception is thrown.
But i want to show the bar to the player regardless whether it is empty or
not.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/5#issuecomment-31317150
.

from barapi.

Maybe, but i guess it should be documented somewhere.
(If i have some freetime later this day i'll create a PR adding some Javadocs.)

from barapi.

Here is my PR:
Added some javadocs
#6

from barapi.

The method should be validated and throw a more related exception, as it is, when a plugin does this the error is related to BarAPI since BarAPI is the component dividing by zero, and hence the developer assumes it's a problem with the API rather than their plugin.

from barapi.

The stack trace should show where the original error occurred from. It is no different from misuse of the Bukkit API such as passing in a y value for a Location greater than the world height?

from barapi.

Passing an invalid y value does not throw an exception; however when trying to do something like add two locations from different worlds, Bukkit will throw a more related exception.
Of course, up to you though.

from barapi.

There is something more, i was unable to test until now.

What happens if a negative value is passed?

Then the health would become greater than maxHealth but with 20 ticks delay.
a) The timer will never stop except there is another setMessage called.
b) This will potentially throw an exception either client or server side and it can't be tracked back to the plugin.

EDIT: Just tested that using -1.
No exception but strange bahaviour:

from barapi.

That is rather odd behaviour. PR merged.

from barapi.