Comments (4)
@williamkwao most likely to do with checking for NonNull fields https://github.com/confuser/graphql-constraint-directive/blob/master/index.js#L53 Should probably pass in an argument to the String/Number field types to check whether a value is required or not
from graphql-constraint-directive.
@confuser Thanks! I'll take a stab at it. If that is the case, shouldn't it default to the conditional without the GraphQLNonNull check?
graphql-constraint-directive/index.js
Line 55 in 11b0136
from graphql-constraint-directive.
@confuser I was going through the code to figure out why this is not working for optional fields but I couldn't find why this is happening. I'll take a good look again to see whats going on. If you can give me a brief explanation on why this is happening, I'll make a PR for this issue.
from graphql-constraint-directive.
Any updates on this issue? Thanks!
Update: I've updated to the last version and now it works correctly, I think this ticket can be closed, thanks!
from graphql-constraint-directive.
Related Issues (20)
- price_Float_NotNull_min_1_max_100000 no validation HOT 1
- Changelog HOT 1
- Expose validate functions HOT 1
- Error compiling with tsc (TS7016)
- Include directive definition in graphql-config to enable in vscode language server
- Documentation generator fails when astNode missing HOT 1
- apollo4.d.ts is out of date HOT 1
- Validation not done on values which are zero HOT 1
- Apollo server type conflict using createApollo4QueryValidationPlugin HOT 1
- Invalid format type for list fields
- allow null or undefined as a constraint parameter on arrays HOT 1
- Validation error message at field level HOT 1
- minField only works with scalar
- [Bug] Maximum call stack size exceeded HOT 1
- array constraint directive: Cannot read properties of undefined (reading 'options')" HOT 1
- `apollo4.d.ts` has wrong type for `createApollo4QueryValidationPlugin` HOT 2
- Unable to use a custom format HOT 1
- Cannot read properties of undefined (reading 'args') when schema has a custom directive with argument HOT 1
- Apollo4: validateQuery silently fails validating queries HOT 1
- getVariableValues: unhandled errors
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from graphql-constraint-directive.