Giter VIP home page Giter VIP logo

Comments (4)

confuser avatar confuser commented on May 26, 2024 1

@williamkwao most likely to do with checking for NonNull fields https://github.com/confuser/graphql-constraint-directive/blob/master/index.js#L53 Should probably pass in an argument to the String/Number field types to check whether a value is required or not

from graphql-constraint-directive.

williamkwao avatar williamkwao commented on May 26, 2024 1

@confuser Thanks! I'll take a stab at it. If that is the case, shouldn't it default to the conditional without the GraphQLNonNull check?

} else if (field.type === GraphQLString) {

from graphql-constraint-directive.

williamkwao avatar williamkwao commented on May 26, 2024

@confuser I was going through the code to figure out why this is not working for optional fields but I couldn't find why this is happening. I'll take a good look again to see whats going on. If you can give me a brief explanation on why this is happening, I'll make a PR for this issue.

from graphql-constraint-directive.

madarco avatar madarco commented on May 26, 2024

Any updates on this issue? Thanks!

Update: I've updated to the last version and now it works correctly, I think this ticket can be closed, thanks!

from graphql-constraint-directive.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.