Comments (22)
BNNorman
commented on June 25, 2024
1
Hmm, i think you need to bring a failing device to the next meetup otherwise its a lot of guesswork.
from air-quality-web.
bsimmo
commented on June 25, 2024
1
@adamjennison reports it's working for him
it works for me on Win10 Chrome, Edge(EdgeHTML) Edge(Chromium)
and all the mobile Android device I could test on.
Many thanks, could see any other show stoppers (other than the veroni shading area often picking up the wrong sensor value for the wrong area, but I think we have an issue for that, it doesn't make it unusable)
from air-quality-web.
CrazyRobMiles
commented on June 25, 2024
It looks like it might be this:
The message doesn't appear on a working load.
from air-quality-web.
CrazyRobMiles
commented on June 25, 2024
Ha. Ignore that. Just done a reload on the working page and it worked fine, with that error. I've had a look at the code and it is just a sensible error message.
from air-quality-web.
CrazyRobMiles
commented on June 25, 2024
Tried some different machines and it works OK on them. Maybe an issue with cookies and the migratin of the url to sensors
from air-quality-web.
bsimmo
commented on June 25, 2024
This happens on all of mine, different browser different devices.
theat little box is
tippy-tooltip
it does not go away and close itself.
Everything loads in the background, but it's not usable.
I think it happened with the most recent update (1.3 or the sensor header change)
from air-quality-web.
BNNorman
commented on June 25, 2024
Works ok on my amazon tablet with Silk browser. Though theres a significant lag between opening a chart and the graph appearing.
from air-quality-web.
sbrl
commented on June 25, 2024
Hey! That looks like the first-run tutorial isn't working correctly. The null cell polygons don't really any thing to do with that bit of the code.
Very strange. Which browsers is this in @CrazyRobMiles & @bsimmo? If it's an issue, we might just have to disable the first-run tutorial.
from air-quality-web.
CrazyRobMiles
commented on June 25, 2024
I'm not sure if it is a browser thing. I think it is more likely that it uses a cookie to determine if it has displayed or not and gets stuck on devices where it hasn't been displayed. Could the change of url affected where it stores the cookie for the first run tutorial? (or am I just completely misunderstanding how it works?)
from air-quality-web.
CrazyRobMiles
commented on June 25, 2024
The first run tutorial is a nice thing to have, but I think we can do without it if it is the cause of the problem.
from air-quality-web.
BNNorman
commented on June 25, 2024
The cookie idea is easy to test. Perhaps ben could flush his out and retry?
from air-quality-web.
bsimmo
commented on June 25, 2024
Already flushed out all the browsers before I posted, happens on chrome,
edge and edge-chrome.
Mobile and mobile (desktop) and Win10.
AQ... and Sensors...
Disable the tutorial for now, test on the beta site to get it to work.
See if that is the problem.
Why it has stopped working, I don't know.
…On Sun, 27 Oct 2019, 5:20 pm Brian, ***@***.***> wrote:
Tge cookie idea is easy to test. Perhaps ben could flush his out and retry?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#55?email_source=notifications&email_token=ACYAXNZUR5LHDUQNDLEJDMDQQW5WBA5CNFSM4JERG6K2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECLDO6A#issuecomment-546715512>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACYAXN5F6BUZL3F2Y7WLI4TQQW5WBANCNFSM4JERG6KQ>
.
from air-quality-web.
bsimmo
commented on June 25, 2024
It is but it needs to be working now.
Bug fix it later on the beta site.
I can't bring the PC :-( and the mobile is just Android 9 with up to date browsers, I think all browser on Android use Chromium underneath.
I could bring the laptop, but it's a school laptop, uses just Edge (EdgeHTML engine) and is locked down of course.
The best I could do above was tell you the module/function the box was from
via the dev tools.
And that it worked fine before when the title was Air Quality (or whatever it
used to say). It could be a chrome/chromium/EdgeHtml change but doubt all
three engines had similar changes on two platforms.
I have recorded what it does.
but (and in Incognito/Private)
- it gives you the Changelog
- than you close that
- you get the 'locked' screen with just the small box.
-- I can guess the how to use guide does not display properly and so you cannot exit out of it.
If there is any other logging I can do on the PC?
Not sure how to enable Dev tools etc on Android.
If we're lucky it may just go away.
…On Sun, 27 Oct 2019, 7:53 pm Brian, ***@***.***> wrote:
Hmm, i think you need to bring a failing device to the next meetup
otherwise its a lot of guesswork.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#55?email_source=notifications&email_token=ACYAXNZVVDB7L42NUYJVRUTQQXPUPA5CNFSM4JERG6K2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECLGO5Q#issuecomment-546727798>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACYAXN4EWDFDZ4DQG4UVBM3QQXPUPANCNFSM4JERG6KQ>
.
from air-quality-web.
CrazyRobMiles
commented on June 25, 2024
I’ve seen this problem on my devices. I think we should move the tutorial behind a button so that we can test it.
… On 27 Oct 2019, at 20:59, Ben ***@***.***> wrote:
It is but it needs to be working now.
Bug fix it later on the beta site.
Can't bring the PC :-( and the mobile is just Android 9 with up to date
browsers.
I could bring the laptop, but it's a school laptop, uses just Edge and is
locked down of course.
The best I could do above was tell you the module/function the box was from
via the dev tools.
And it worked fine before when the title was Air Quality (or whatever it
used to say). It could be a chrome/chromium/EdgeHtml change but doubt all
three engines had similar changes on two platforms.
One thing I didn't test (yet) is if I actually go through the full
introduction as I just hit cancel each time.
If there is any other logging I can do on the PC?
Not sure how to enable Dev tools etc on Android.
If we're lucky it may just go away.
On Sun, 27 Oct 2019, 7:53 pm Brian, ***@***.***> wrote:
> Hmm, i think you need to bring a failing device to the next meetup
> otherwise its a lot of guesswork.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#55?email_source=notifications&email_token=ACYAXNZVVDB7L42NUYJVRUTQQXPUPA5CNFSM4JERG6K2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECLGO5Q#issuecomment-546727798>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ACYAXN4EWDFDZ4DQG4UVBM3QQXPUPANCNFSM4JERG6KQ>
> .
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
from air-quality-web.
bsimmo
commented on June 25, 2024
Just looked at this on my PC again.
For now you can hit ESC * to bypass the failing tutorial* (the small rectangular box (Chrome/Edge)
For mobile (Android anyway) devices I would suggest not using it or showing it to anyone for now
(*as a side note, you may need to click in the little box and then press ESC)
(*assuming it is that)
from air-quality-web.
sbrl
commented on June 25, 2024
Whether the tutorial is launched or not is actually checked by using a localStorage key, not a cookie. This is done here:
https://github.com/ConnectedHumber/Air-Quality-Web/blob/dev/client_src/js/Tour.mjs#L141-L154
I could certainly put it behind a button. Let's try that.
from air-quality-web.
sbrl
commented on June 25, 2024
Fixed it. Turns out there was a change in the API in a recent update of Shepard.js, which is used for the tour. It should now be working on the beta version in ~10 minutes.
from air-quality-web.
sbrl
commented on June 25, 2024
There, it should be deployed now. Don't forget to reload without cache with Ctrl + Shift + R, and if you want the first-run wizard to appear again try a private browsing window.
If it works for everyone, then I'll release this to stable.
from air-quality-web.
BNNorman
commented on June 25, 2024
beta works fine on my desktop (Windows 10) using Firefox.
However, the 'loading' circles take a long time to end and the charts take a long time to appear.
from air-quality-web.
sbrl
commented on June 25, 2024
Thanks for checking @BNNorman! Yeah, it is taking a while. It's because of the last_seen SQL query - it takes a long time on the dataset we've acquired lol.
Is there an index on readings.s_or_r? I think it might help
@bsimmo: Thanks. Yeah, I need to debug that.... again.
from air-quality-web.
BNNorman
commented on June 25, 2024
Yes there is an index on s_or_r. Last seen would be max(s_or_r).
from air-quality-web.
sbrl
commented on June 25, 2024
Yeah, that's what it uses, @BNNorman. Hrm, might have to rethink that one :-/
from air-quality-web.
Related Issues (20)
- Display the currently selected reading type on the heatmap when loading the device graph HOT 1
- Migration: Slow HTTP API calls HOT 9
- When clicking sensors on the AQ Map (sometimes) the map just zooms HOT 5
- Sensor filter HOT 12
- Mosquitto stuck Address in use (1883) HOT 3
- FTW says 6 hours ago but last reading was 12:00 (now 16:00) HOT 13
- Repeated measurement types above chart HOT 5
- Can the charts be made to open with data rather than just say error: no data recorded HOT 1
- Slow charts HOT 5
- POST request : Error 500 Internal Server Error HOT 7
- API action list-devices-near is not quite working - it returns only the same sensor HOT 8
- device.visible has no effect on the map HOT 7
- API and documents not working HOT 3
- Circles, on Opening the Map, don't disappear HOT 2
- Sensor not showing up correctly on current (0.14-dev) beta site HOT 5
- Last seen on chart is wrong HOT 6
- Wrong base URL in the API docs HOT 1
- graph not showing data for device bonus-a-abp HOT 5
- Integration with custom sensors and visual optimizations ? HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from air-quality-web.