Comments (2)
AArnott
commented on July 3, 2024
A removeAllCancelled method would allow causing unexpected side effects leading to malfunction elsewhere. If other code had registered callbacks, we wouldn't want your example code above to remove those other callbacks as they may still be needed.
Instead, consider the recommended pattern is to remove only the callback you added, via the return value of the onCancelled function:
cancellationtoken/src/CancellationToken.ts
Lines 74 to 79 in f272405
I recommend we close the issue.
from cancellationtoken.
conradreuter
commented on July 3, 2024
I recommend we close the issue.
Agreed.
from cancellationtoken.
Related Issues (9)
- Memory leak for long-lived tokens HOT 25
- Remove .js.map file or add .ts file HOT 1
- Make CancellationToken.create return a proper type HOT 1
- Release 2.3 HOT 7
- The exports don't match the types when imported with ESM HOT 4
- Allow CancellationError to be constructed without giving a reason
- Set name property on cancellation errors
- Stop the timeout without cancelling HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cancellationtoken.