Remove type parameter from `Natural` (WIP) about compare HOT 5 OPEN

CC me (need to think about this a bit more...)

from compare.

I've only looked at this crate for a very short while. How to handle the .get<Q: ?Sized>() model that maps have?

Without a type parameter on Natural, at least it is fine to use with both Compare<K> and Compare<Q>

I tried the following, which fails because the default comparator is C = Natural<K> so the restriction C: Compare<Q> forces K == Q :(

    pub fn contains<Q: ?Sized>(&self, key: &Q) -> bool
        where K: Borrow<Q>,
              C: Compare<Q>,
    {

With this said, I think for this use case a phantom-type based approach works better. Custom closure comparators can't cope with the Q vs K scheme anyway.

from compare.

This is super out of cache but I think the Borrow adaptor is supposed to be for that...?

https://github.com/contain-rs/compare/blob/master/src/lib.rs#L215-L234

from compare.

aha thanks!

from compare.

Hm I can't figure out how to use it. I don't think I can, if I require my Bmap<K, V, C> to have a C: Compare<K>, then that can't be converted in any way into something that can compare two borrowed Q values (where K: Borrow<Q>).

from compare.