Comments (3)
Without going into if the ask makes sense or not, I'd say the flag should be the opposite - i.e. by default have the interface enabled, thus having the existing current behavior as "the" default.
The ticket says the default will be true
.
from plugins.
Without going into if the ask makes sense or not, I'd say the flag should be the opposite - i.e. by default have the interface enabled, thus having the existing current behavior as "the" default.
from plugins.
Without going into if the ask makes sense or not, I'd say the flag should be the opposite - i.e. by default have the interface enabled, thus having the existing current behavior as "the" default.
The ticket says
the default will be true
.
Oh right !
FWIW, you don't say what's the name of the attribute, and thus: "The option will control whether the defined interface will be brought up by the plugin. The default will be true." can pretty much mean anything - i.e. a disableInterface
knob controls whether the defined interface will be brought up by the plugin, and if it defaults to true, you'd get a disabled interface.
I'm happy we share the default should be the "current behavior", but I still think the issue could be a bit more explicit; Near the end of the description you do propose a name for the knob; could you maybe introduce it it the beginning ? IMO that's more explicit / less confusing.
from plugins.
Related Issues (20)
- Calico CNI failed with hcnCreateEndpoint failed in Win32: The provided policy configuration is invalid or missing parameters. (0x803b000d) HOT 3
- The test badge in the Readme.md file reports test failure
- host-device: wrong interface naming
- Getting validateIfName: interface name ABC already exists on reboot
- Top-down documentation for bridge VLAN options HOT 5
- Why not expose netlin.LinkAttrs in parameter to config queue number of veth pair? HOT 1
- macvlan: error killing pod: Link not found HOT 11
- host-device cannot use linux wireless devices HOT 1
- documentation seems a bit unclear HOT 2
- how does `bridge` work with `vlanTrunk` ? HOT 1
- Route attributes
- ipvlan can support muti-network policy? If not, any plan for this? HOT 1
- go1.20.4 stdlib CVEs
- need to double check PR962 comment HOT 2
- host-local: save IP for pod and namespace for restore after reboot
- feature: allow configuration of num_queues for macvlan and ipvlan
- ptp: Enabling L2 mode HOT 2
- Feature Request: ipvlan/macvlan support IfAlias as a backup for master HOT 1
- host-device continuously outputs 'Link not found' error, and Pod will stuck on Terminating state
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from plugins.