Multiple flock calls on the same filename deadlocks about fuse-overlayfs HOT 6 CLOSED

thanks for the amazing reproducer, it was very easy to reproduce locally and see immediately the issue.

I've opened a PR here: #82

Could you verify if it works for you? I've done some tests based on your code and the locking seems to work fine (if I had a sleep while we hold the lock, I can see other processes are waiting for it)

from fuse-overlayfs.

I experienced it too, package managers tend to do that and end up deadlocked.

from fuse-overlayfs.

Thanks! It's always nice when removing code solves an issue :-)

I can no longer reproduce this issue with your patch applied. As far as I can tell, it also (still) does the right thing when flock is called on a file in a lower fs. That is: a flock call on a file in the container image from one container does not result in a locked file for a second container.

from fuse-overlayfs.

Thanks! It's always nice when removing code solves an issue :-)

yes, I don't remember last time I could literally delete the bug :-)

from fuse-overlayfs.

Time for a new release?

from fuse-overlayfs.

Time for a new release?

working on one: #84

from fuse-overlayfs.