Allow custom JsonSerializerSettings inside the client about contentful.net HOT 6 CLOSED

Please see submitted PR

from contentful.net.

Excellent suggestion!

In your opinion, should this on a per call, per client or a global setting?

A few options spring to mind.

1. Make it part of the ContentfulOptions passed in when creating the client.
2. Make it a property on the client that needs to be set before/after each request.
3. Add settings as an overload to each request.

from contentful.net.

I think you should expose this on the constructor and/or as a property on the client. Having separate overloads would be too much in my opinion. Especially because you can always use multiple instances of the client itself, if you have different needs in different parts of your application.

from contentful.net.

Thinking about it, using a property could make the most sense as you can then preset the settings to a sensible default for contentful (e.g. adding AssetJsonConverter, etc.). Using the ContentfulOptions could then be an additional way in order to easily support the configuration framework in mvc.

from contentful.net.

Sounds reasonable, I'll look into it.

from contentful.net.

Again, thanks for the contributions! This is now in the latest version on NuGet.

from contentful.net.