Giter VIP home page Giter VIP logo

Comments (38)

Aktanusa avatar Aktanusa commented on July 24, 2024

Sure, though what colors do you think I should change the following to?

Blue
Green
Yellow
Orange
Red
Purple
Gray

It shouldn't be too hard, except I don't know which colors to change and what the new colors should be.

from cookiemonster.

darkstar avatar darkstar commented on July 24, 2024

There are online simulators to see how colors look with different kinds of color blindness (protanopia is the most common):
http://www.etre.com/tools/colourblindsimulator/
Also, various "color design guides" are available, e.g. this one:
http://colororacle.org/design.html

from cookiemonster.

Aktanusa avatar Aktanusa commented on July 24, 2024

Ah, thanks though I was semi hoping someone would just do the work for me in terms of telling me what the new colors are, lol.

from cookiemonster.

YoavKa avatar YoavKa commented on July 24, 2024

Just give me a few days and I can come up with new colors for you :) Im color blind so I think I would do alright

from cookiemonster.

Aktanusa avatar Aktanusa commented on July 24, 2024

Great, thanks!

from cookiemonster.

YoavKa avatar YoavKa commented on July 24, 2024

I was messing around with the colors a bit. and I think changing the lime to actual green, the orange to red and the red to dark red (rgb: 127,0,0) should fix the problem for now :)

from cookiemonster.

Aktanusa avatar Aktanusa commented on July 24, 2024

Okay thanks! I'll add this to next release, assuming beta doesn't take forever to get to live!

from cookiemonster.

YoavKa avatar YoavKa commented on July 24, 2024

Thanks! as the colors really make it hard for me to use the add-on, would it be possible to make a small release just for the color changes? I would really appreciate it...

from cookiemonster.

Aktanusa avatar Aktanusa commented on July 24, 2024

Hmm, sure, though now looking more into it, it's more complex than I first thought since there are static elements on the screen I don't constant update (for performance). Luckily not that much more complex. Also another thing, I can only update the colors that I've added with the add on, not all the colors in CC. Is that okay? To update all colors in CC would require a lot more work.

from cookiemonster.

YoavKa avatar YoavKa commented on July 24, 2024

The colors of the normal CC are OK, but thanks for the offer :) I can help you update the code if you like me to

from cookiemonster.

Aktanusa avatar Aktanusa commented on July 24, 2024

Thanks for that offer, but I don't think this is complex enough to require that much time, lol. It's mostly CSS of global variables I've already set that need to be change, so not too hard. I'm just now verifying that indeed those colors work, aka creating a temp web page with the original colors/your chosen colors and then using the simulator @darkstar posted. Hope my verifying doesn't offend you...

from cookiemonster.

YoavKa avatar YoavKa commented on July 24, 2024

No offense taken

from cookiemonster.

Aktanusa avatar Aktanusa commented on July 24, 2024

Great! Well hopefully you can wait at most a day. I'm not sure I'll be able to finish this morning as I really should be sleeping at the moment, lol.

from cookiemonster.

YoavKa avatar YoavKa commented on July 24, 2024

Thanks! There is no harsh, dont worry :)

from cookiemonster.

Aktanusa avatar Aktanusa commented on July 24, 2024

I tried using the colors you suggested but I don't think it works good enough for all three types of color blindness. I tried finding colors that would work, but I don't have enough colors to make it work yet. I need more time to figure out what colors to use.

from cookiemonster.

YoavKa avatar YoavKa commented on July 24, 2024

What about adding an option to change the default colors to costum colors? Whould it be hard to implement?

from cookiemonster.

Aktanusa avatar Aktanusa commented on July 24, 2024

That would be easier, as then I don't have this wall of what colors to use, lol

from cookiemonster.

YoavKa avatar YoavKa commented on July 24, 2024

lol. Would you need help with the coding of such feature?

from cookiemonster.

Aktanusa avatar Aktanusa commented on July 24, 2024

I was using the colors suggested by the Wikipedia here, but that's only 3 colors. I was trying to use other shades of gray with black being one of them, but black and white shouldn't be used, I think. I technically don't need help coding it, as it is just some more config to add, but this is the second time you asked, so do you really want to help?

from cookiemonster.

YoavKa avatar YoavKa commented on July 24, 2024

I wouldn't mind helping you coding, but if you don't like me too it's no big deal. Another idea I had was instead of creating one color plate for all of the color blind types, adding 4 color plates: the default one, and one for each main type of color blindness. I think that would make it easier to choose colors for each plate.

from cookiemonster.

Aktanusa avatar Aktanusa commented on July 24, 2024

Hmm, that's a great idea as then I have more flexibility on what colors to choose. On the flip side, allowing one to choose any color is even better. I guess the biggest problem in that choice is to make a color wheel to choose the color... As for you helping, I know eventually if this becomes big enough, I should really have other people help out, but I do like the fact that I know what all the code does (or at least most of it, lol). So basically, I don't know? If you really want to help, I guess it's fine?

from cookiemonster.

YoavKa avatar YoavKa commented on July 24, 2024

It's ok, I know that feeling. If you change your mind you can ask me for help. If it's ok with you, I can try and make a color wheel for you to use, so you can check the code before you add it to the add-on.

from cookiemonster.

YoavKa avatar YoavKa commented on July 24, 2024

apparently there is in HTML5 which I think will do the job just fine.

from cookiemonster.

Aktanusa avatar Aktanusa commented on July 24, 2024

that sounds fine, color wheel away! So HTML 5 has a color wheel built in? If so, I see what you mean, not much coding to do, lol.

from cookiemonster.

YoavKa avatar YoavKa commented on July 24, 2024

yes indeed :) I think the coding using this element will be very easy

from cookiemonster.

Aktanusa avatar Aktanusa commented on July 24, 2024

Yep, I just saw it. Very easy indeed. Thanks for the help. You motivated me to finish this real soon, lol. Barring any interruptions, I may have it up soon.

from cookiemonster.

YoavKa avatar YoavKa commented on July 24, 2024

Great! You can contact me in the feature for any help you need,

from cookiemonster.

Aktanusa avatar Aktanusa commented on July 24, 2024

Cool, thanks!

from cookiemonster.

Aktanusa avatar Aktanusa commented on July 24, 2024

According to this, IE and Safari doesn't support the color input =/. I may need to write a custom one.

from cookiemonster.

YoavKa avatar YoavKa commented on July 24, 2024

:/ I made a small color chooser based on the which according to this site works on every browser, would you like me to send it to you?

from cookiemonster.

Aktanusa avatar Aktanusa commented on July 24, 2024

Is it jscolor?

from cookiemonster.

YoavKa avatar YoavKa commented on July 24, 2024

no, an html/js code I made in the last 30 minutes

from cookiemonster.

Aktanusa avatar Aktanusa commented on July 24, 2024

oh your message got screwed up, I didn't see you type in "input type=range" part

from cookiemonster.

Aktanusa avatar Aktanusa commented on July 24, 2024

Well I feel bad that you spent 30 mins on it, but unless it's better than jscolor, I'll probably go with jscolor =/.

from cookiemonster.

YoavKa avatar YoavKa commented on July 24, 2024

don't feel bad, I had fun :) if there is a problem with using jscolor tell me.

from cookiemonster.

Aktanusa avatar Aktanusa commented on July 24, 2024

Whew, that took a lot more changes than I thought. Well I've refactored the code that now it's easy to change the colors. Now to add the option to change it...

from cookiemonster.

Aktanusa avatar Aktanusa commented on July 24, 2024

Added in Version 1.0465.12

from cookiemonster.

YoavKa avatar YoavKa commented on July 24, 2024

that's amazing! Thanks!

from cookiemonster.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.