Nodes about terraform-aws-eks HOT 9 CLOSED

I think that managed nodes will be out of scope for now... we can in-scope them again when they support more configurability / and or custom amis

from terraform-aws-eks.

AMI

from terraform-aws-eks.

I am erring towards the Amazon AMI.

So long as we are happy with:

• Docker as the container runtime
• No general ssh access to nodes

It reduces maintenance, and means that there will be little difference between managed node groups and standard ASG groups ...

from terraform-aws-eks.

+1 for not having to maintain GPU-ready AMI 👍

from terraform-aws-eks.

+1 for not having to maintain GPU-ready AMI 👍

To be clear no-one has tested if it works for our needs ... I have no idea about the complexity of using it... so 🤷‍♂

from terraform-aws-eks.

I say let's stick with Amazon EKS AMI until we have a concrete use-case or performance/reliability optimization we need to tackle that doesn't fit in it.

from terraform-aws-eks.

What should the API look like for defining node groups?

The two ideas I have are:

Single module that manages cluster and groups ... likely a lot of complexity on the inside!

module "production-eks-cluster" {
  source  = "cookpad/eks/aws"
  version = "1.0.1"

  name = "production"

  ... some other config ...

  node_groups = [
    {
      type = "managed"
      instance_type = "t3.medium"
    },
    {
      type = "fargate"
      selector = {
        namespace = "example"
      }
    }
  ]
}

vs

The top level module sets up the cluster ... nodes are added by reference to a config object in the output
of the cluster module...

Implementation is much simpler... but usage is arguably a bit more messy ... but perhaps simpler to understand.

module "production-eks-cluster" {
  source  = "cookpad/eks/aws/"
  version = "1.0.1"
  name = "production"

  ... some other config ...
}

module "production-eks-node-group" {
  source  = "cookpad/eks/aws//managed_node_group"
  version = "1.0.1"
  cluster = module.production-eks-cluster.cluster
  instance_type = "t3.medium"


  ... some other config ...
}

module "production-eks-fargate-profile" {
  source  = "cookpad/eks/aws//fargate_profile"
  version = "1.0.1"
  cluster = module.production-eks-cluster.cluster

  ... some other config ...
}

I am erring on the side of the second one ... @ettiee do you have a view since you actually used https://ghe.ckpd.co/infra/eks-terraform the most of anyone?

from terraform-aws-eks.

In the past I've used the second approach with good results. It is simpler to understand and more flexible.

You can then wrap both modules on another module or on a single configuration for defining a concrete instance of as cluster + nodes, which mitigates your concern I think.

from terraform-aws-eks.

ASG node group is working fine...

Fargate is a nice to have at this point: #34

from terraform-aws-eks.