Giter VIP home page Giter VIP logo

Comments (6)

cool-RR avatar cool-RR commented on May 19, 2024

from pysnooper.

lleontop avatar lleontop commented on May 19, 2024

Still kind of sceptical about it since most mature modules have good packaging and as I could see Django now has install dependencies not bundled (pytz and sqlparse) and we might need to have more dependencies in the future (and we will need to add the dependency and the dependency dependencies code) but as I said it's ok not a real issue right now, we can revisit this if it is required.

from pysnooper.

lleontop avatar lleontop commented on May 19, 2024

Also the travis error seems to be the order and the scope of imports to get the version. It seems that during pysnooper package install it needs to get the version and to do that it also imports pysnooper.py that needs decorator but pip hasn't installed any dependecies yet. I can have a look at it and possibly change the order and scope of imports if you think it would be beneficial

from pysnooper.

cool-RR avatar cool-RR commented on May 19, 2024

You could, but these problems happen and they'll continue to happen in different ways. I know it's a backwards kind of solution, but removing all dependencies lets me spend less time with these problems.

from pysnooper.

bittner avatar bittner commented on May 19, 2024

As I commented on commit 5c31dfc, __init__.py shouldn't do anything but define attributes. Problems with importing the package to install in setup.py are typically related to import issues (circular imports, import of dependencies not present or similar).

That's why importing your own package in setup.py tends to be discouraged in popular speech, but really this is never a problem unless you do dirty things in __init__.py. It just must be empty or almost empty. No logic that triggers the machinery.

from pysnooper.

cool-RR avatar cool-RR commented on May 19, 2024

I disagree, sorry.

from pysnooper.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.