Memory leak while code injection in tweak about electra HOT 20 OPEN

How's this memory leak?
Also, is admob_key_regex actually initialized somewhere?

from electra.

oh, sorry, I missed to add that. will update the question.
reply here:
Test is a singleton:

+ (instancetype)defaultManager {
	static AdManager *_instance;
	static dispatch_once_t once;
	dispatch_once(&once, ^{
		_instance = [[Test alloc] init];
	});
	return _instance;
}

- (instancetype)init {
	self = [super init];
    if (self) {
        testArray = [NSMutableSet set];
        admob_key_regex = [NSRegularExpression regularExpressionWithPattern:@"^(ca-app-pub)-[0-9]{16}/[0-9]{10}"
	                                                                options:NSRegularExpressionCaseInsensitive
	                                                                  error:nil];

    }
	return self;
}

from electra.

My test code works on iOS 10 with substrate; I just want to test it on iOS 11 and find this issue.

Because everytime I run it, the object class type is changed, it can be UIActivityContinuationManager, or __CFData, or __NSArrayM, so every time it will crash, as these classes' object has no method: firstMatchInString:options:range:

For example, a live debug session said:

2018-01-20 16:34:38.164117+0800 BannerExample[1012:59623] ******AdManager****** _logos_method$_ungrouped$GADBannerView$setAdUnitID$:256 <AdMob Banner> unit id:ca-app-pub-3940256099942544/2934735716
2018-01-20 16:34:38.164202+0800 BannerExample[1012:59623] -[__NSCFString firstMatchInString:options:range:]: unrecognized selector sent to instance 0x1c4056800

isn't 0x1c4056800 suppoed to be NSRegularExpression

from electra.

@liuxuan30 Can you please send me your test app & tweak?

from electra.

Let me try to wrap it up, as my tweak is huge, I need to isolate it.

from electra.

@liuxuan30 Sure, minimal isolated reproducible case would be cool.

from electra.

tweak: https://pan.baidu.com/s/1c37nr7i
app: https://pan.baidu.com/s/1dG65rDv
expired in 7 days. Hope the speed work for you.

from electra.

if the app is slow to download, just go to google's page download one

from electra.

I'm using b6-3. Simply install the tweak, and launch the app and wait to crash in viewDidLoad

from electra.

@stek29 any idea for this crash?

from electra.

@liuxuan30 I was unable to download those files :\

from electra.

ehhhh.. I will try google drive then

from electra.

test app: https://drive.google.com/open?id=1XJfFZUeC2C5NgwUIo_zU8F2qhdQgG1aH
tweak: https://drive.google.com/open?id=1pY4k2faLVXUK2J5IOJwWH1R3vzhqFA3G

let me know if it works for you

from electra.

I'm sorry @stek29 I managed to download it but didn't know if you still need it.

from electra.

@parrotgeek1 you met the same issue?

from electra.

@stek29 @coolstar just to raise hand again, will this be fixed in public release?

from electra.

I can’t reproduce this

from electra.

@nullpixel you mean fixed? May I ask what version of electra you cannot reproduce? Thanks

from electra.

I tried on the latest cydia branch, maybe my test tweak isn’t sufficient? Did you send a reproduction tweak or?

from electra.

yes, see #49 (comment)
I uploaded both test app and tweak on google drive. You might also want check my other comments with code snippets and logs about the issue.

from electra.