Giter VIP home page Giter VIP logo

Comments (8)

miekg avatar miekg commented on July 22, 2024

todo:

  • stubzones
  • porting all previous test (in progress)
  • stubzone tests
  • bugfixes, code cleanup
  • configuration from Corefile
  • Multi zones tests
  • Nodata responses
  • Integration tests

from coredns.

miekg avatar miekg commented on July 22, 2024

sooo, sometimes the tests fails with

--- FAIL: TestLookup (0.36s)
    setup_test.go:192: answer 3 should have a Target of "a.server1.prod.region1.skydns.test.", but has "b.server1.prod.region1.skydns.test."
    setup_test.go:120: ;; opcode: QUERY, status: NOERROR, id: 25332
        ;; flags: qr aa rd ra; QUERY: 1, ANSWER: 7, AUTHORITY: 0, ADDITIONAL: 3

        ;; QUESTION SECTION:
        ;*.region1.skydns.test. IN   SRV

        ;; ANSWER SECTION:
        *.region1.skydns.test.  300 IN  SRV 10 14 0 sub.server1.
        *.region1.skydns.test.  300 IN  SRV 10 14 0 unresolvable.skydns.test.
        *.region1.skydns.test.  300 IN  SRV 10 14 80 sub.server2.
        *.region1.skydns.test.  300 IN  SRV 10 14 8080 b.server1.prod.region1.skydns.test.
        *.region1.skydns.test.  300 IN  SRV 10 14 8080 b.server6.prod.region1.skydns.test.
        *.region1.skydns.test.  300 IN  SRV 10 14 8080 c.sub.region1.skydns.test.
        *.region1.skydns.test.  300 IN  SRV 10 14 8080 dev.server1.

        ;; ADDITIONAL SECTION:
        b.server1.prod.region1.skydns.test. 300 IN  A   10.0.0.2
        b.server6.prod.region1.skydns.test. 300 IN  AAAA    ::1
        c.sub.region1.skydns.test.  300 IN  A   10.0.0.1

    setup_test.go:164: answer 0 should have a Header Name of "a.server1.prod.region1.skydns.test.", but has "b.server1.prod.region1.skydns.test."
    setup_test.go:127: ;; opcode: QUERY, status: NOERROR, id: 25332
        ;; flags: qr aa rd ra; QUERY: 1, ANSWER: 7, AUTHORITY: 0, ADDITIONAL: 3

        ;; QUESTION SECTION:
        ;*.region1.skydns.test. IN   SRV

        ;; ANSWER SECTION:
        *.region1.skydns.test.  300 IN  SRV 10 14 0 sub.server1.
        *.region1.skydns.test.  300 IN  SRV 10 14 0 unresolvable.skydns.test.
        *.region1.skydns.test.  300 IN  SRV 10 14 80 sub.server2.
        *.region1.skydns.test.  300 IN  SRV 10 14 8080 b.server1.prod.region1.skydns.test.
        *.region1.skydns.test.  300 IN  SRV 10 14 8080 b.server6.prod.region1.skydns.test.
        *.region1.skydns.test.  300 IN  SRV 10 14 8080 c.sub.region1.skydns.test.
        *.region1.skydns.test.  300 IN  SRV 10 14 8080 dev.server1.

        ;; ADDITIONAL SECTION:
        b.server1.prod.region1.skydns.test. 300 IN  A   10.0.0.2
        b.server6.prod.region1.skydns.test. 300 IN  AAAA    ::1
        c.sub.region1.skydns.test.  300 IN  A   10.0.0.1

FAIL

from coredns.

miekg avatar miekg commented on July 22, 2024

For some reason *.region1.skydns.test. 300 IN SRV 10 14 8080 c.sub.region1.skydns.test. get included, which seems wrong.

from coredns.

miekg avatar miekg commented on July 22, 2024

Ah wait sub should be included - which makes sense. So b.server1.prod.region1.skydns.test. is included but (strangely) a.server1.prod.region1.skydns.test. has dropped out of the set. Replacing it with the c.sub ones... #hmmm

from coredns.

miekg avatar miekg commented on July 22, 2024

Had changed an optimization (bx in etcd.go) to not include n.Key which made it do the wrong thing. (Might actually be a bug in SkyDNS as well...)

from coredns.

miekg avatar miekg commented on July 22, 2024

see e62eb2c

from coredns.

miekg avatar miekg commented on July 22, 2024

nodata responses and integration tests left.

from coredns.

miekg avatar miekg commented on July 22, 2024

All fixed, closing in favour of integration tests in #100

from coredns.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.