Limit does not work properly about typeahead.js HOT 11 CLOSED

This may be the issue

twitter/typeahead.js#1435

from typeahead.js.

Could be, but the code seems pretty different from what is in that bug report, and I don't pretend to understand what it's supposed to be doing.

Here's what I think is the current code:

                function async(suggestions) {
                    suggestions = suggestions || [];
                    if (!canceled && rendered < that.limit) {
                        that.cancel = $.noop;
                        that._append(query, suggestions.slice(0, that.limit - rendered));
                        rendered += suggestions.length;
                        that.async && that.trigger("asyncReceived", query);
                    }
                }

In the bug it refers to code that should be:

var idx = (that.limit > rendered) ? rendered : that.limit;
that._append(query, suggestions.slice(0, idx));

Would love a fix for this. It's a pretty wonky problem.

from typeahead.js.

replace that._append with the two lines suggested and that fixed it for me.

from typeahead.js.

Thanks @mwjackson. I tried that, but when I put those two lines in place, I couldn't get back any results at all, no matter how many results the backend returned.

from typeahead.js.

This is how my async function looks:

            function async(suggestions) {
                suggestions = suggestions || [];
                if (!canceled && rendered < that.limit) {
                    that.cancel = $.noop;
                    rendered += suggestions.length;
                    var idx = (that.limit > rendered) ? rendered : that.limit;
                    that._append(query, suggestions.slice(0, idx));
                    that.async && that.trigger("asyncReceived", query);
                }
            }

from typeahead.js.

Yes! That fixed it! What should we do to get this change checked in? Are you a committer?

from typeahead.js.

No... just commit it to a branch and submit a PR
On 11 Jan 2016 21:10, "Mike Lissner" [email protected] wrote:

Yes! That fixed it! What should we do to get this change checked in? Are
you a committer?

—
Reply to this email directly or view it on GitHub
#43 (comment)
.

from typeahead.js.

@mwjackson do you want to be a committer?

@lenovouser is the owner and seems open to giving people privileges

from typeahead.js.

OK, Pull Request created. I'm hopeful we can get this released quickly. It's a pretty major issue unless I'm mistaken.

from typeahead.js.

This has been merged! Closing.

from typeahead.js.

Tracking this for release soon, see #55

from typeahead.js.