Giter VIP home page Giter VIP logo

Comments (10)

skovmand avatar skovmand commented on June 8, 2024 1

+1 I'm also getting errors with require.js using the bundle, because typeahead.js and bloodhound are not defined. Please restore - it should be very simple.

from typeahead.js.

yanickrochon avatar yanickrochon commented on June 8, 2024

Ah! Nevermind, I forgot I had changed the defined call from typeahead.js to typeahead.

This should be something to change, as noted in some previous issues....

from typeahead.js.

yanickrochon avatar yanickrochon commented on June 8, 2024

Using the most recent JS, in this repo's dist folder, I see that define does not declare anything anymore. This breaks my require.config.

Restoring define(['jquery'], ... to define('bloodhound', ['jquery'], ... etc. resolve this. Why was it removed or changed anyway?

from typeahead.js.

yanickrochon avatar yanickrochon commented on June 8, 2024

Please, fix this before releasing 0.11.2 (See issue #55)

from typeahead.js.

elgervb avatar elgervb commented on June 8, 2024

+1 I'm also getting errors with requireJS. Please rename the definition from typeahead.js to typeahead

I've fixed this locally by copying the 0.11.1 library and changed

 if (typeof define === "function" && define.amd) {
        define("typeahead.js", [ "jquery" ], function(a0) {
            return factory(a0);
        });
    }

to

 if (typeof define === "function" && define.amd) {
        define("typeahead", [ "jquery" ], function(a0) {
            return factory(a0);
        });
    }

after this change requireJS can correctly load the typeahead library. Please fix :-)

from typeahead.js.

yanickrochon avatar yanickrochon commented on June 8, 2024

I don't know why this hasn't been published, yet. The dist folder does contain the fix, but the bower module and other downloads do not. The current version should at least be 0.12.0 to reflect this change and project state... It is confusing.

from typeahead.js.

jcrben avatar jcrben commented on June 8, 2024

@yanickrochon It is indeed. We're not really doing a very good job - are you interested in helping out? I'm not sure the owner @lenovouser is still checking out the repo.

It looks like the npm package is handled by https://github.com/mariusz-kraj but he isn't a collaborator for this repo.

from typeahead.js.

yanickrochon avatar yanickrochon commented on June 8, 2024

@jcrben npm can handle such cases, where repo maintainers are no longer active, and the goal is to keep the community up-to-date modules. I personally have enough on my hands at the moment to be a maintainer of this project, however I could collaborate, sure, since I am using this widget. What are you suggesting?

from typeahead.js.

jlbooker avatar jlbooker commented on June 8, 2024

FYI, I've initiated a package name dispute with NPM support. We're working on a new release in #55 .

from typeahead.js.

jlbooker avatar jlbooker commented on June 8, 2024

I think was already fixed in 212fe89. The module is registered anomalously now, so the offending line in the Gruntfile has been completely removed. A newer build (from the newer Gruntfile) should fix this.

from typeahead.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.