Giter VIP home page Giter VIP logo

Comments (11)

coreybutler avatar coreybutler commented on June 9, 2024 1

@sitiom as you know, that workflow has never actually worked. Truthfully, it's more hassle than it's worth, especially since our focus is on Runtime. I don't really want users installing from winget with this tool because it just keeps adding issues I don't really have time to deal with. We're planning proper support for winget with Runtime (as well as other install options), so that's where my focus is.

@LorenDorez The innosetup installer sometimes works in the shell you install in and sometimes doesn't. It's an extremely annoying issue with innosetup+windows where Windows isn't signaling completion properly, so things sometimes get updated out of order (seems worst on Windows 10, but happens on 11 and servers too). That's why the docs recommend restarting the shell. So, for your case, you probably will need to manually specify the env vars for the shell you're running in. I'm sorry for that... I wish I had a better answer for you.

from nvm-windows.

coreybutler avatar coreybutler commented on June 9, 2024

We don't maintain the winget installer. It looks like it's not updating the PATH though. See https://github.com/coreybutler/nvm-windows/wiki.

from nvm-windows.

LorenDorez avatar LorenDorez commented on June 9, 2024

If I open a new command prompt everything works just fine. I just can't use nvm in the same shell I install it with.

I'll see it if I can manually set the path in my shell as see if that helps. I had to do that for %NVM_HOME%

from nvm-windows.

sitiom avatar sitiom commented on June 9, 2024

We don't maintain the winget installer. It looks like it's not updating the PATH though. See coreybutler/nvm-windows/wiki.

You actually do, though 😅: https://github.com/coreybutler/nvm-windows/blob/master/.github/workflows/winget.yml. About Winget, It's just running the installer you provided, which means there is no magic happening on the Winget side behind the scenes.

About the workflow error: https://github.com/coreybutler/nvm-windows/actions/runs/6962150119/job/18984279583, can you try manually syncing https://github.com/coreybutler/winget-pkgs up-to-date and rerunning the failed workflow? I think the reason for the failure is due to an outdated fork.

from nvm-windows.

sitiom avatar sitiom commented on June 9, 2024

@sitiom as you know, that workflow has never actually worked.

From the workflow:

Both issues are easily actionable.

Truthfully, it's more hassle than it's worth, especially since our focus is on Runtime. I don't really want users installing from winget with this tool because it just keeps adding issues I don't really have time to deal with.

Like I said, Winget runs the official installer, which means that the issues should not come from the Winget side.

You can try out the thing I suggested above and see if it works. It only takes a minute of your time:

can you try manually syncing coreybutler/winget-pkgs up-to-date and rerunning the failed workflow? I think the reason for the failure is due to an outdated fork.

from nvm-windows.

github-actions avatar github-actions commented on June 9, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

from nvm-windows.

sitiom avatar sitiom commented on June 9, 2024

Bump

from nvm-windows.

github-actions avatar github-actions commented on June 9, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

from nvm-windows.

sitiom avatar sitiom commented on June 9, 2024

Bump

from nvm-windows.

github-actions avatar github-actions commented on June 9, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

from nvm-windows.

sitiom avatar sitiom commented on June 9, 2024

Bump

from nvm-windows.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.