min count + into about counter-rs HOT 2 CLOSED

We already have a Deref impl to give immutable access to the inner HashMap; it sounds like what you're asking for is a DerefMut impl. That way you could just delegate to the retain method.

let mut counter = "abcdefgggg".chars().collect::<Counter<_>>();
counter.retain(|_ch, count| count >= 2);
let as_vec = counter.iter().collect::<Vec<_>>();
assert_eq!(as_vec, vec![('g', 4)]);

I'd be happy to review a PR adding a DerefMut impl; it would have a straightforward path to merging. (I'm on vacation right now and may or may not find time to write such an impl myself.) I don't recommend a PR with the implementations you've suggested; they're too Vec-oriented for my taste.

from counter-rs.

Actually I do see a DerefMut impl on master, and you are completely correct: with both DerefMut and the HashMap's retain method it's possible to apply a minimal count + k_most_common_ordered together in a nice way:

let mut counter: Counter<char, usize> = Counter::init("abcdeffgggg".chars());
counter.retain(|_, count| *count >= 2);
let by_common = counter.k_most_common_ordered(1);
let expected: Vec<(char, usize)> = vec![('g', 4)];
assert!(expected == by_common)

Thanks!

from counter-rs.