bug: type error in `@angular-skyhook/multi-backend` 1.2.1 about angular-skyhook HOT 8 CLOSED

@angular-skyhook/multi-backend 1.3.2 released

from angular-skyhook.

It's possible that upgrading to react-dnd v9, as mentioned in a comment to #430, will also address this issue.

from angular-skyhook.

Sorry for the wait. Latest (^1.3.0) raises the minimum dnd-core version to 9. Please check if this is resolved.

from angular-skyhook.

Sorry for the wait

No worries! Upgrading to version 9 does fix this issue. However, it also created a new issue:

In my app module I've been importing SkyhookDndModule like so (working in 1.1.1)

SkyhookDndModule.forRoot({ backendFactory: createDefaultMultiBackend }),

In version 1.3.0 the following type error is raised:

Argument of type '{ backendFactory: BackendFactory; }' is not assignable to parameter of type 'BackendInput | BackendFactoryInput'.
  Type '{ backendFactory: BackendFactory; }' is not assignable to type 'BackendFactoryInput'.
    Types of property 'backendFactory' are incompatible.
      Type 'BackendFactory' is not assignable to type '() => BackendFactory'.

This can be fixed by creating an exported function which returns createDefaultMultiBackend:

export function backendFactory() {
  return createDefaultMultiBackend;
});

SkyhookDndModule.forRoot({ backendFactory });

I think the real fix is updating createDefaultMultiBackend to have the type () => BackendFactory. See #483

from angular-skyhook.

Did you also update dnd-multi-backend?

from angular-skyhook.

I did see below

from angular-skyhook.

Wait, I read that as "Did you also update @angular-skyhook/multi-backend?" My project only has direct dependencies on @angular-skyhook/core and @angular-skyhook/multi-backend, wouldn't providing dnd-multi-backend be handled by @angular-skyhook/multi-backend?

from angular-skyhook.

Your PR is correct. I also tried to update to dnd-multi-backend v4.0.0 as it's meant to be easier to use with dnd-core v9, but apparently that breaks all dragging, so I will stick with 3.2.1 for now.

from angular-skyhook.