Race detector warnings about hashmap HOT 10 CLOSED

@lunemec are you using the current master branch that included a race fix? if so, can you create a unit test to replicate that behavior?

from hashmap.

Well, I only noticed when creating kinda huge hashmaps. I tested this with my tests, but it did not trigger. Only when I load real data 70MB in heap, then it triggers this. My current revision is this: b893f49

from hashmap.

I'll try to force the newest commit with the fix - dep automatically takes released version.

from hashmap.

Nope, the current master does not work either. I'll write a test case for this.

from hashmap.

Well, I kinda created this problem:

func TestHashMap_SetWithContainer(t *testing.T) {
	type Container struct {
		Map HashMap
	}
	type mapItem struct {
		InnerData HashMap
	}
	var container Container
	for i := 0; i < 10; i++ {
		var innerMap HashMap
		for z := 0; z < 10; z++ {
			innerMap.Set(z, struct{}{})
		}
		container.Map.Set(i, mapItem{InnerData: innerMap})
	}
}

from hashmap.

Well at least I can now fix it by simply moving the HashMap outside of the struct, but I have some metadata packed with it, so that would not be ideal.

from hashmap.

@cornelk do you think a fix is possible? Or should I work around this?

from hashmap.

this is the fixed unit test without a race condition:

func TestHashMap_SetWithContainer(t *testing.T) {
	type Container struct {
		Map *HashMap
	}
	type mapItem struct {
		InnerData *HashMap
	}
	container := Container{Map: &HashMap{}}
	for i := 0; i < 10; i++ {
		innerMap := &HashMap{}
		for z := 0; z < 10; z++ {
			innerMap.Set(z, struct{}{})
		}
		container.Map.Set(i, mapItem{InnerData: innerMap})
	}
}

from hashmap.

Okay, so it was misunderstanding of usage on my part. Could you maybe update readme/doc with a example of this?

from hashmap.

The readme and tests already contain code that shows how to initiate the map: m := &HashMap{}

from hashmap.