Giter VIP home page Giter VIP logo

Comments (13)

corrados avatar corrados commented on July 28, 2024

My MPS750x ride generates a rim piezo signal that is very strong

Are you shure that it is a piezo which detects the rim signal? I would have assumed that it is a switch and not a piezo. How have you setup your pad paramters? You can configure if it shall be a rim pizeo or rim switch.

from edrumulus.

3hhh avatar 3hhh commented on July 28, 2024

from edrumulus.

corrados avatar corrados commented on July 28, 2024

This is a recording of my PD-8 pad which definitely has a switch and no piezo on the second channel (first channel is the head piezo, second channel is the rim switch):
grafik
It looks very similar to what is in your file mps750x_ride_all:
grafik
I am very sure that you also have a switch and no pizeo on the rim.

from edrumulus.

corrados avatar corrados commented on July 28, 2024

On test you could do is to measure the resistance of the rim if you have a multi-meter at hand. Then you can measure the Ohms when the pad is not touched and measure the Ohms when you press the choke (i.e., press the edge of the cymbal as if you would choke a real cymbal) which should close the rim switch.

from edrumulus.

3hhh avatar 3hhh commented on July 28, 2024

Kk, I'll see whether I can do that.

Anyway this line here only allows at most 10^((31-44)/10) = 5% as threshold.

from edrumulus.

corrados avatar corrados commented on July 28, 2024

Yea, you are right. I think I have to fix this, soon. It's already too long on my TODO list :-).

from edrumulus.

corrados avatar corrados commented on July 28, 2024

Ok, TODO is done now: 55516d7

from edrumulus.

corrados avatar corrados commented on July 28, 2024

Anyway this line here only allows at most 10^((31-44)/10) = 5% as threshold.

BTW, the line you referenced is for piezo rim triggers but you have to set your pad to rim switch which then uses the new formula I have just changed.

from edrumulus.

3hhh avatar 3hhh commented on July 28, 2024

On test you could do is to measure the resistance of the rim if you have a multi-meter at hand. Then you can measure the Ohms when the pad is not touched and measure the Ohms when you press the choke (i.e., press the edge of the cymbal as if you would choke a real cymbal) which should close the rim switch.

The resistance goes down from MOhm to 0 on the choke. I guess that indicates it's a switch?

from edrumulus.

corrados avatar corrados commented on July 28, 2024

Yes, definitely. It's a switch.

from edrumulus.

3hhh avatar 3hhh commented on July 28, 2024

Thanks for the update!

It kind of works now.
"Kind of" because it's less reliable than with the original module: E.g. if I hit the bell or bow with medium velocity, edrumulus will trigger a rimshot.

from edrumulus.

corrados avatar corrados commented on July 28, 2024

I assume you are using the same resistors for the rim switch as for the piezos, right? Maybe it makes sense to play a bit with the resistor values to improve the rim switch detection.
In my setup with Roland pads, the same resistors work fine for piezo and switch but that may not be the case with your Millenium pads.

from edrumulus.

3hhh avatar 3hhh commented on July 28, 2024

The signal and SNR is just fine, i.e. there's no need to play with the resitors at the moment. However I verified with my sound card that there is a rim signal whenever I hit the bell. That signal has roughly the same strength as the one I get whenever I hit the rim, which imho indicates that Millenium uses a different algorithm to identify rim, bow and bell. Hitting the bow also triggers the rim signal, albeit at a much lower level.

Anyway the original issue was fixed, i.e. this one can be closed.

from edrumulus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.