Giter VIP home page Giter VIP logo

Comments (16)

splitbrain avatar splitbrain commented on May 31, 2024 1

This is now implemented but not (unit) tested, yet. Since the bureaucracy plugin is quite complex and only has few tests, there might be a whole bunch of side effects I did not think of.

Bureaucracy and struct has been updated on the wizmo and ifak wikis and is ready to be (manually) tested. See https://www.dokuwiki.org/plugin:struct:bureaucracy for documentation. @detman @stvoigt please check it out and see if it satisfies your requirements.

from dokuwiki-plugin-struct.

stvoigt avatar stvoigt commented on May 31, 2024 1

Support asterisk for mandatory fields does not work. Even if a struct_schema is optional, the asterisk is shown (but the fields keep optional). See Foo: ifak:templates:forms:new_test.

from dokuwiki-plugin-struct.

splitbrain avatar splitbrain commented on May 31, 2024 1

You might need to clear your browser cache. It looks much different for me.

from dokuwiki-plugin-struct.

stvoigt avatar stvoigt commented on May 31, 2024

As we are making the schemes dynamically changeable, it would be great just name the used scheme in bureaucracy so you do not have to change the form when changing the scheme. Thus the form should always provide the same input stuff as the editor used when editing a page connected with a scheme.
Syntax: use_stuct_scheme: scheme-name
Would be great to make "scheme-name" a variable to handover via the URL as other bureaucracy inputs right now. That would make forms reauseable for different, similar stuff.
I think, we would need these "comment" things we used in data-plugin to describe the values within a scheme. This should then be displayed within the bureaucracy too.

What still seems tricky, is the handover to the template or better said, making the template changeable... I have no idea how to make this more useable and maintainable...

from dokuwiki-plugin-struct.

splitbrain avatar splitbrain commented on May 31, 2024

I think that wouldn't be flexible enough. Currently we often prefill data entries from a bureaucracy generated page without asking the user. Your suggestion would require the user to fill out every struct field themselves.

Also you may want to use user input in struct data and in the page via template variables. So there needs to be a way to use input in placeholders and struct.

from dokuwiki-plugin-struct.

stvoigt avatar stvoigt commented on May 31, 2024

Where do you prefill the data entries within the wizard already or when applying the vaules to the template? In the fist case the values could be prefilled in the valueEditors. In the second case we could exclude certain struct-entries from form, e.g.: use_stuct_scheme: scheme-name ! abc, xyz. Would this be useful?

The second part of your comment would mean from my point of view to make struct-data useable in templates again. But as mentioned above, I have no how to make that flexible. If you use the names from the schema as names for the input-types in bureaucracy (automatically), they would be useable in the templates to, would'nt it? (But that is not that flexible when changing struct scheme)

from dokuwiki-plugin-struct.

splitbrain avatar splitbrain commented on May 31, 2024

Single fields now work but there's still thing to do on them before moving on to full schemas:

  • support error class for highlighting validation errors
  • support asterisk for mandatory fields
  • adjust styling to have bureaucracy and struct fields have matching sizes

from dokuwiki-plugin-struct.

stvoigt avatar stvoigt commented on May 31, 2024

Styling could be more consistent. See in Foo: ifak:templates:forms:new_project or ifak:templates:forms:new_meeting as examples.

from dokuwiki-plugin-struct.

stvoigt avatar stvoigt commented on May 31, 2024

Handover of data to the bureaucracy form does not work yet or at least I do not know the right syntax. (maybe not implemented yet => new ticket needed?)

I have tried
"new_project?@target_system@=Test" (See FOO: ifak:projects:start&rev=1459778633)
"[email protected]_system@=Test" (See Foo: ifak:projects:start&rev=1459778593)
but non of them worked.

from dokuwiki-plugin-struct.

splitbrain avatar splitbrain commented on May 31, 2024

I don't understand your comment about the styling. Can you explain what is inconsistent? Maybe add an annotated screenshot?

from dokuwiki-plugin-struct.

splitbrain avatar splitbrain commented on May 31, 2024

The bureaucracy plugin expects the URL placeholders to have underscores instead of spaces and dots for some reason (I am sure it made perfect sense and some point in the past :suspect:). So ifakproject.target_system becomes ifakproject_target_system. I adjusted foo>ifak:projects:start accordingly.

from dokuwiki-plugin-struct.

stvoigt avatar stvoigt commented on May 31, 2024

what I have meant with better styling:

  • alignment of labels differes between normal fields and stuct fields
  • textboxes have different widths (approx. double) => I guess, that the empty space at sturct textboxes is resvered for hints, but than the bureaucracy textboxes should have the same empty space too
  • dropdown-boxes are wider than normal struct text boxes (I guess thats because of the drop down triangle)
  • date boxes (bureaucracy) are aligned left, but all other are aligned ight

struct_bureaucracy

from dokuwiki-plugin-struct.

stvoigt avatar stvoigt commented on May 31, 2024

Absolutely, that helped a lot :)

from dokuwiki-plugin-struct.

splitbrain avatar splitbrain commented on May 31, 2024

@stvoigt can you confirm that this now works as expected?

from dokuwiki-plugin-struct.

stvoigt avatar stvoigt commented on May 31, 2024

Yes I can :)

from dokuwiki-plugin-struct.

splitbrain avatar splitbrain commented on May 31, 2024

perfect :-)

from dokuwiki-plugin-struct.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.