Giter VIP home page Giter VIP logo

Comments (8)

TrevorJTClarke avatar TrevorJTClarke commented on August 18, 2024 1

We'd have to update the docs too

sounds great!
Hit me with the list, i can do a first pass tonight or tmoro night.
Cheers

from cosmos-kit.

pyramation avatar pyramation commented on August 18, 2024 1

thumbs up! go ahead and we are excited about your PR!
we can help update docs w @liujun93

from cosmos-kit.

pyramation avatar pyramation commented on August 18, 2024

I think it's a fair point! I suppose in this world, we'd have one wallet per package?

from cosmos-kit.

TrevorJTClarke avatar TrevorJTClarke commented on August 18, 2024

Yep! If that is okay with you - I can do a split to make this work, however it will likely need to be like the following for backward compat:

# Inside packages:
/keplr (just exports the combined set of mobile + ext)
/keplr-mobile
/keplr-extension
/cosmostation
/cosmostation-mobile
/cosmostation-extension

if you're good with that @pyramation then i can contribute that

from cosmos-kit.

sascha1337 avatar sascha1337 commented on August 18, 2024

from cosmos-kit.

pyramation avatar pyramation commented on August 18, 2024

Yep! If that is okay with you - I can do a split to make this work, however it will likely need to be like the following for backward compat:

# Inside packages:
/keplr (just exports the combined set of mobile + ext)
/keplr-mobile
/keplr-extension
/cosmostation
/cosmostation-mobile
/cosmostation-extension

if you're good with that @pyramation then i can contribute that

I think that would work! Thanks! Before you go and do the work, we may want to merge a branch first as we may have quite a few changes...

We'd have to update the docs too, let's run this by @liujun93 so we can get a checklist of all things to consider, we're going to meet tonight and can go over this asap!

from cosmos-kit.

TrevorJTClarke avatar TrevorJTClarke commented on August 18, 2024

See PR #128 - I've been using an internal project to test the connections and can prove its working.

Will finalize this for all wallets and do some documentation, then it will be ready.

NOTE: I was unable to have 100% success with Vectis & Trust wallets, I assume these are still in flux. Vectis appears to not conform to all the hooks.

from cosmos-kit.

pyramation avatar pyramation commented on August 18, 2024

closed with #129

from cosmos-kit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.