Giter VIP home page Giter VIP logo

Comments (4)

Shak2000 avatar Shak2000 commented on June 12, 2024

Hi. I am interested in working on this issue.

from cdp-backend.

evamaxfield avatar evamaxfield commented on June 12, 2024

Update: I think this and #119 are the two primary reasons that the pipeline is currently failing for seattle-staging.

There are some files we are using that have filenames / URIs like https://some-domain.com/route?some-guid and when we save the files with our current pattern they get saved to our storage as gs://{infra}/route?some-guid... the ? or any special URI handling character causes fsspec.exists to fail it's check which fails the whole event upload.

Definitely need to save these files with their content hash as the filename.

from cdp-backend.

evamaxfield avatar evamaxfield commented on June 12, 2024

You can see this behavior:

fireo.fields.errors.FieldValidationFailed: "TextField" failed validation with value gs://cdp-jackson-dev-065.appspot.com/photo-1523665307251-7f4e0e7b23fc?ixid=MnwxMjA3fDB8MHxwaG90by1wYWdlfHx8fGVufDB8fHx8

from cdp-backend.

isaacna avatar isaacna commented on June 12, 2024

Update: I think this and #119 are the two primary reasons that the pipeline is currently failing for seattle-staging.

There are some files we are using that have filenames / URIs like https://some-domain.com/route?some-guid and when we save the files with our current pattern they get saved to our storage as gs://{infra}/route?some-guid... the ? or any special URI handling character causes fsspec.exists to fail it's check which fails the whole event upload.

Definitely need to save these files with their content hash as the filename.

Really nice find, I didn't realize that the special characters would actually cause exists to fail. And I agree that the filename should be the content hash in this case.

from cdp-backend.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.