VPA CRDs not installed correctly about charts HOT 11 OPEN

Hi @sebastien-prudhomme

Thanks for maintaining the chart, my team is currently trying to install the VPA chart on our ArgoCD deployment with helmfile (pre-templated) .
Then we faced same issue as this.

Currently, it's difficult to add following annotation by some patch (like kustomization's since the CRD is defined in the ConfigMap as the text.

Can we have helm value to add arbitrary annotation to the CRD, or install CRD in the plain Helm's manner?

argocd.argoproj.io/compare-options: IgnoreExtraneous

Thanks.

from charts.

One way I have seen this done is for the CRDs to live in a sub-chart:

https://github.com/elastic/cloud-on-k8s/tree/main/deploy/eck-operator

It removes the CRDs when uninstalling the main chart, which is not good.

from charts.

Hi @bodgit

I'm not sure of how to fix the problem.

The first solution is to use these annotations on CRDs:

argocd.argoproj.io/compare-options: IgnoreExtraneous
argocd.argoproj.io/sync-options: Prune=false

ArgoCD wants still to prune them, which sould not append thank to one of the annotations, but the application is considered as synced, thanks to the other annotation.

Currently the chart doesn't allow adding annotations on CRDs only.

from charts.

One way I have seen this done is for the CRDs to live in a sub-chart:

https://github.com/elastic/cloud-on-k8s/tree/main/deploy/eck-operator

from charts.

I also meet this problem when installing this helm chart using argocd,
The CRDs are not created, the webhook is also not created

from charts.

I can no more reproduce the problem with Argo CD 2.7.7. The CRDs doesn't appear anymore in the Argo CD UI.

@ctrongminh Which version of Argo CD are you using and which version of VPA Helm chart?

Can you give me the Application custom resource used to install VPA with Argo CD?

from charts.

I'm currently using ArgoCD 2.6.14 and I can see the issue described in the original post using this resource. Hope this helps replicate.

apiVersion: argoproj.io/v1alpha1
kind: Application
metadata:
  name: vertical-pod-autoscaler
  namespace: argocd
spec:
  destination:
    namespace: kube-system
    server: 'https://kubernetes.default.svc'
  source:
    repoURL: 'https://cowboysysop.github.io/charts/'
    chart: vertical-pod-autoscaler
  project: default
  syncPolicy:
    automated:
      # Do not allow this to prune or it will remove the CRDs. See: https://github.com/cowboysysop/charts/issues/339
      prune: false 
      selfHeal: false

from charts.

I'm hitting this when deploying on EKS where the nodes use calico-cni. The job cannot install the CRDs because the kube API is not available from the nodes unless the pod in question is using host networking, which is not configurable via the chart. This is a common interaction of EKS with calico (the control plane nodes do not run any calico pods).

from charts.

hitting the same problem, do we have to install the CRDs via a k8s job and not by using the dedicated CRDs chart directory?
installing the CRDs this way with extra helm hooks disables some flexibility, we also want to deploy some VPA CRs along with this chart using helm hooks, but the CRDs keeps deleting.

from charts.

@oavner what is your context? ArgoCD? Version?

This is done with a job because CRDs in the dedicated directory are not updated when an Helm release is upgraded.

What I can do is add an option to disable managing CRDs in the Helm chart so people who have problems can install them as they want to.

from charts.

May be add parameter .Values.crds.annotations to CRD templates, this is annoying issue with Out Of Sync state

from charts.