Comments (4)
Thanks for the suggestion. I haven't really looked at ctest yet. As we're migrating to CMake we should presumably also integrate with ctest.
That being said, our do_regtests
script has been refined for over 20 years and contains many bells and whistles that we have come to rely on. So, I don't think we can retire it anytime soon.
from cp2k.
That being said, our
do_regtests
script has been refined for over 20 years and contains many bells and whistles that we have come to rely on. So, I don't think we can retire it anytime soon.
I don't suggest to completely retire it, just to gradually remove some functionalities out of it, as things are being covered by ctest
, particularly the scheduling. I think it's still a perfectly valid choice to have do_regtests
to wrap the cp2k
execution and tests, but I think it should be considered more carefully on what is included in the python script beyond the basic functionality of performing regression tests (re: #2996)
from cp2k.
PS: Feel free to check my template about a design for the ctest
testsuite. It includes unit testing, regression testing, packaging tests, and example testing. If you want to discuss it in more details, let me know.
from cp2k.
Just saw that CP2K_ENABLE_REGTESTS
makes it write files in the source folder. That is really bad and error prone in multi-build environments like when packaging and trying to build for multiple MPI environments. I understand that it was done to have minimal effect on the do_regtest.py
, but still that creates dangerous setups for the end-user in order to accommodate the limitations of the test scripts.
from cp2k.
Related Issues (20)
- Request to add the function of "outputting <S**2> of excited state"
- Added TARGET_ GROWTH, Shake Lagrangian Multipliers only increase without decreasing
- SGP refactoring broke SIRIUS HOT 9
- [Feature Request] GPU Resident Single Precision and Mixed Precision for GEEP QMMM
- RI-RPA quadrature points convergence HOT 5
- Segmentation fault with amber parameter files for small systems HOT 1
- Feature Request: Non-local vdW functionals for ENERGY_CORRECTION (HARRIS/DC)
- Check required version of SIRIUS at startup
- Problem Compiling CP2K
- Segfault in ELPA HOT 5
- MGGA functionals for ROKS and SIC methods
- Broyden_mixing_new does not work
- nvcc with cuda_toolkit 12.4 not support gcc versions later than 12 HOT 3
- OpenMP variable `ngpts` in cp2k-2024.1/src/pw/pw_methods.F HOT 10
- Inquiry about Differences and Connections between CPMD and CP2K. HOT 4
- Compilation cp2k on AMD EPYC 9654/9754 Using Intel oneAPI. HOT 6
- Rerun slow regtest once more before flagging it
- How to call itimes variable in manybody forces evaluation HOT 1
- How to set pseudo-hydrogen?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cp2k.