Giter VIP home page Giter VIP logo

Comments (13)

acehead avatar acehead commented on August 20, 2024 1

Great, worked like a charm, migration was done successfully as well. Thanks for your help!

from aws-s3.

andris-sevcenko avatar andris-sevcenko commented on August 20, 2024

Can you try updating to the just-released 1.1. version of the plugin?

from aws-s3.

acehead avatar acehead commented on August 20, 2024

Just updated, same issue persists, it seems that https://github.com/craftcms/aws-s3/blob/1.1.0/src/Volume.php is still missing storageClass property

from aws-s3.

andris-sevcenko avatar andris-sevcenko commented on August 20, 2024

Right, because it should have been removed by https://github.com/craftcms/aws-s3/blob/master/src/migrations/m180929_165000_remove_storageclass_setting.php

Can you check if your craft_migrations table has that migration entry? If it does, what date does it have?

from aws-s3.

acehead avatar acehead commented on August 20, 2024

Just checked, no such entry there. Craft says that there are migrations pending, but right after hitting the finish button I get the abovementioned error.

from aws-s3.

andris-sevcenko avatar andris-sevcenko commented on August 20, 2024

Can you get a stack trace for that error from the log files?

from aws-s3.

acehead avatar acehead commented on August 20, 2024

stacktrace.txt

from aws-s3.

andris-sevcenko avatar andris-sevcenko commented on August 20, 2024

/var/www/config/twig-webpack-extension.php seems to be calling craft\services\Globals->getSetByHandle('common').

I'm not sure that calling Craft functionality from config files is a good idea, as demonstrated by this particular issue. You're invoking Craft before it has a chance to run its migrations and this can lead to unpredictable results. Can you disable that, let the migrations run and see what happens?

from aws-s3.

acehead avatar acehead commented on August 20, 2024

You're absolutely right, but this was the only way we could make that happen without changing original plugin code.
Commented it out, unfortunately problem is still there, see stacktrace
stacktrace2.txt

from aws-s3.

andris-sevcenko avatar andris-sevcenko commented on August 20, 2024

Ugh. This is not cool.

Okay. Here's the plan. Re-adding this property (since it does nothing), cutting a 1.1.1 release and for the next release require at least 1.1.1 to update and delete that property. That should ensure that everyone updates to 1.1.1, run the migration to get rid of the setting and the property is safe to be removed in the next version.

from aws-s3.

acehead avatar acehead commented on August 20, 2024

sounds great, waiting for 1.1.1 to be released

from aws-s3.

andris-sevcenko avatar andris-sevcenko commented on August 20, 2024

Should be released as of now.

from aws-s3.

andris-sevcenko avatar andris-sevcenko commented on August 20, 2024

I must say, for an instant I was scared when I saw your email :)

from aws-s3.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.