Comments (8)
Hi, thanks for getting in touch!
Looks like this is fixed in the latest version of nystudio107/craft-code-editor
(see changelog: https://github.com/nystudio107/craft-code-editor/blob/develop/CHANGELOG.md#1016---20231130).
It worked as expected up to and including 1.0.13
and is fixed in 1.0.16
, but 1.0.16
is not yet available on Packagist.
You can temporarily fix this by requiring "nystudio107/craft-code-editor": "1.0.13"
or "nystudio107/craft-code-editor": "dev-develop#58e469ba2c2798150706bd11ae7fa6b854006208 as 1.0.15"
in your composer.json
and running composer update
.
(I also raised a PR to update the composer requirement for the CKEditor plugin to skip over versions 1.0.14
and 1.0.15
.)
from ckeditor.
@realjoshharrison, yes, it would be best to remove it then.
from ckeditor.
It worked as expected up to and including 1.0.13 and is fixed in 1.0.16, but 1.0.16 is not yet available on Packagist.
I didn't tag that release properly, thanks for the heads up. I've re-tagged it, we should be good to go.
from ckeditor.
+1 I am experiencing this also on a brand new install of CK Editor.
To note: this is a multisite and I am also getting an additional JS error:
linkui.js:40 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'join')
at a.value (linkui.js:40:48)
Attaching a screenshot of the editor screen
from ckeditor.
Hi Iwona, thank you for taking a look so quickly, and the explanation!
I'll wait for the update, and use your fix if I run into problems 🙂
from ckeditor.
Hi @i-just - I have added "nystudio107/craft-code-editor": "1.0.13"
to my composer.json
and updated, which all works as expected. Can I ask whether I need to do remove it again once the proper fix ships?
from ckeditor.
The fix has already shipped; apparently there's a bug downstream in the Monaco editor package which no longer exposes the global API, but I put in a fix already.
You just got unlucky if you ran into this, updating within the window that the regression went unnoticed.
The semver in the CK Editor's composer.json
is:
"nystudio107/craft-code-editor": "^1.0.8"
...which means it will get updates to the latest version automatically, so you don't need to put it in your project's composer.json
, you can just do:
composer update nystudio107/craft-code-editor
...to update to the latest version at any time.
from ckeditor.
This issue should be closed, it's already been addressed downstream in craft-code-editor
nystudio107/craft-code-editor@dea2736
from ckeditor.
Related Issues (20)
- ckeditor/convert redactor to ckeditor issue with matrix feilds HOT 1
- Adjusting CkEditor Config leads to Exception HOT 1
- Nested entries lost when running resave entries command HOT 1
- Congis in Json Files HOT 1
- Missing documentation about oembed in Redactor->CKEditor HOT 3
- [Question] Extending CKEditor docs
- Cannot read properties of undefined (reading 'onDidPaste') HOT 2
- Stripping out HTML attributes regardless of settings HOT 5
- Nested entry card shows "Invalid entry ID" after undo HOT 1
- Nested entries aren't displayed for revisions HOT 2
- Invalid Entry ID when adding a nested entry after upgrading to 4.0.5 HOT 1
- New Config is not showing in editor HOT 8
- Table property and cell property not showing HOT 2
- Not able to drag items into toolbar HOT 7
- Nested Entries Still Render On The Front End When Disabled HOT 2
- Issue with custom TwigFunction after CKEditor 4.1.0 HOT 11
- Nested Entries not rendering at all on front end HOT 6
- Changes are not saved in CKEditor field while in "source" mode. HOT 1
- Unable to edit an image by double clicking on it HOT 4
- Nested entries within CKEditor fields sometimes fail to copy to other enabled sites HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ckeditor.