`monaco is not defined` on CP CKEditor configs about ckeditor HOT 8 CLOSED

Hi, thanks for getting in touch!

Looks like this is fixed in the latest version of nystudio107/craft-code-editor (see changelog: https://github.com/nystudio107/craft-code-editor/blob/develop/CHANGELOG.md#1016---20231130).

It worked as expected up to and including 1.0.13 and is fixed in 1.0.16, but 1.0.16 is not yet available on Packagist.

You can temporarily fix this by requiring "nystudio107/craft-code-editor": "1.0.13" or "nystudio107/craft-code-editor": "dev-develop#58e469ba2c2798150706bd11ae7fa6b854006208 as 1.0.15" in your composer.json and running composer update.

(I also raised a PR to update the composer requirement for the CKEditor plugin to skip over versions 1.0.14 and 1.0.15.)

from ckeditor.

@realjoshharrison, yes, it would be best to remove it then.

from ckeditor.

It worked as expected up to and including 1.0.13 and is fixed in 1.0.16, but 1.0.16 is not yet available on Packagist.

I didn't tag that release properly, thanks for the heads up. I've re-tagged it, we should be good to go.

from ckeditor.

+1 I am experiencing this also on a brand new install of CK Editor.

To note: this is a multisite and I am also getting an additional JS error:

linkui.js:40 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'join')
    at a.value (linkui.js:40:48)

Attaching a screenshot of the editor screen

from ckeditor.

Hi Iwona, thank you for taking a look so quickly, and the explanation!

I'll wait for the update, and use your fix if I run into problems 🙂

from ckeditor.

Hi @i-just - I have added "nystudio107/craft-code-editor": "1.0.13" to my composer.jsonand updated, which all works as expected. Can I ask whether I need to do remove it again once the proper fix ships?

from ckeditor.

The fix has already shipped; apparently there's a bug downstream in the Monaco editor package which no longer exposes the global API, but I put in a fix already.

You just got unlucky if you ran into this, updating within the window that the regression went unnoticed.

The semver in the CK Editor's composer.json is:

    "nystudio107/craft-code-editor": "^1.0.8"

...which means it will get updates to the latest version automatically, so you don't need to put it in your project's composer.json, you can just do:

composer update nystudio107/craft-code-editor

...to update to the latest version at any time.

from ckeditor.

This issue should be closed, it's already been addressed downstream in craft-code-editor nystudio107/craft-code-editor@dea2736

from ckeditor.