Task input field broken after #1 about react-native-animated-todo HOT 10 OPEN

So, shouldn't we use Factory because it messes up memoization?

from react-native-animated-todo.

Hey @rohitghosal @dimaportenko, I have created a PR and reverted the component which caused the issue, very sorry for the issue caused. Till this gets merged, you can just replace the task-list.tsx component with the code in the link below.

https://github.com/vipulbhj/react-native-animated-todo/blob/master/src/components/task-list.tsx

I will look into detail as to what actually caused the animation to re-render so many times. Thanks for reporting 🌻🌻🌻🌻🌻🌻

from react-native-animated-todo.

Looks like works with 👆 @vipulbhj can you elaborate what was the issue? I was about to try Native Base, but now I'm doubt. I don't want to deal with such kinds of problems.

Well, I don't have any problem, everything is fine for me, I'm sure it's for something else, I already tried Native Base and I haven't had serious problems, well I haven't used it in complex things either

from react-native-animated-todo.

@vipulbhj I found out that #1 broke the app. It basically cause rerender whole list on any action. Check attached video

@craftzdog my suggestion revert changes meanwhile

from react-native-animated-todo.

That looks bad, let me check this and get a fix in. Thanks for reporting, and sorry for the bug 😅. I will send a PR like right now

from react-native-animated-todo.

Looks like works with 👆
@vipulbhj can you elaborate what was the issue? I was about to try Native Base, but now I'm doubt. I don't want to deal with such kinds of problems.

from react-native-animated-todo.

It was not NativeBase, I messed up the memorization 😅😅😅.

NativeBase doesn't have first party support for animations, so everything from other libraries was working fine. It was lack of experience with reanimated 2 that caused the issue.

I am shocked I didn't test this before sending the PR.

I guess human errors are harder to catch by humans 😅😅😅

I am sorry

from react-native-animated-todo.

Hey all, we can close this issue now since the PR has been merged.

from react-native-animated-todo.

So, shouldn't we use Factory because it messes up memoization?

I am not sure that caused the issues, still looking into it, will give you a detailed feedback on this soon :)

from react-native-animated-todo.

Hi, @vipulbhj Still waiting for this.

Thanks

So, shouldn't we use Factory because it messes up memoization?

I am not sure that caused the issues, still looking into it, will give you detailed feedback on this soon :)

from react-native-animated-todo.