Comments (10)
So, shouldn't we use Factory
because it messes up memoization?
from react-native-animated-todo.
Hey @rohitghosal @dimaportenko, I have created a PR and reverted the component which caused the issue, very sorry for the issue caused. Till this gets merged, you can just replace the task-list.tsx
component with the code in the link below.
https://github.com/vipulbhj/react-native-animated-todo/blob/master/src/components/task-list.tsx
I will look into detail as to what actually caused the animation to re-render so many times. Thanks for reporting
from react-native-animated-todo.
Looks like works with
👆 @vipulbhj can you elaborate what was the issue? I was about to try Native Base, but now I'm doubt. I don't want to deal with such kinds of problems.
Well, I don't have any problem, everything is fine for me, I'm sure it's for something else, I already tried Native Base and I haven't had serious problems, well I haven't used it in complex things either
from react-native-animated-todo.
@vipulbhj I found out that #1 broke the app. It basically cause rerender whole list on any action. Check attached video
@craftzdog my suggestion revert changes meanwhile
telegram-cloud-document-4-5829978153640004256.mp4
from react-native-animated-todo.
That looks bad, let me check this and get a fix in. Thanks for reporting, and sorry for the bug
from react-native-animated-todo.
Looks like works with
@vipulbhj can you elaborate what was the issue? I was about to try Native Base, but now I'm doubt. I don't want to deal with such kinds of problems.
from react-native-animated-todo.
It was not NativeBase, I messed up the memorization
NativeBase doesn't have first party support for animations, so everything from other libraries was working fine. It was lack of experience with reanimated 2
that caused the issue.
I am shocked I didn't test this before sending the PR.
I guess human errors are harder to catch by humans
I am sorry
from react-native-animated-todo.
Hey all, we can close this issue now since the PR has been merged.
from react-native-animated-todo.
So, shouldn't we use
Factory
because it messes up memoization?
I am not sure that caused the issues, still looking into it, will give you a detailed feedback on this soon :)
from react-native-animated-todo.
Hi, @vipulbhj Still waiting for this.
Thanks
So, shouldn't we use
Factory
because it messes up memoization?I am not sure that caused the issues, still looking into it, will give you detailed feedback on this soon :)
from react-native-animated-todo.
Related Issues (8)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-native-animated-todo.