UIManager['CRAWKWebView'] is no longer supported about react-native-wkwebview HOT 14 CLOSED

This is an issue with the (newer) version of React Native you're using, not an issue with this repo. As the warning suggests, use UIManager.getViewManagerConfig('CRAWKWebView') instead.

from react-native-wkwebview.

@shirakaba It's related to this repo code, not mine.
https://github.com/CRAlpha/react-native-wkwebview/blob/master/WKWebView.ios.js#L399

from react-native-wkwebview.

I haven't followed React Native for a while. Looking at the warning, it seems the code is deprecated. Feel free to submit a PR and I'll be happy to merge it. Although I am not sure whether this change will be backward compatible.

from react-native-wkwebview.

@indapublic Sorry for the misunderstanding; I see what you mean. A PR would be appreciated.

Although I am not sure whether this change will be backward compatible.

Yes – at the very least, this should involve a check of whether the method getViewManagerConfig really exists on UIManager. If it exists, use UIManager.getViewManagerConfig('CRAWKWebView'); otherwise, fall back to UIManager.CRAWKWebView.

from react-native-wkwebview.

Sounds good. Do you want to make the change? @shirakaba

from react-native-wkwebview.

@insraq Unfortunately I don't have time to test (and won't for a while), but here's a tentative PR: #223

@indapublic sorry for the trouble, but would you like to test whether my branch fixes your issue?

from react-native-wkwebview.

@shirakaba, sure but tomorrow probably

from react-native-wkwebview.

@shirakaba Looks good for me, but you are forgot change goBack and goForward methods. Just checked, I don't have any permissions for pushing to your branch. Should I create separate PR or just wait for your response?

from react-native-wkwebview.

@indapublic You can make a separate PR and I will merge it. Also it would be nice to extract all the duplicated code into a method.

from react-native-wkwebview.

@indapublic Sorry, find-and-replace didn't show up goBack and goForward in my interface so I missed them. I've amended the PR.

I misunderstood 'squash and merge' and looks like I've accidentally merged the amended branch it into master. I'll revert that.

Also it would be nice to extract all the duplicated code into a method.

Makes sense! Don't have a minute to spare for that at the moment, so will leave the PR open.

from react-native-wkwebview.

Sorry, @indapublic could you make a PR of your own, referencing my original PR if you wish, that extracts the duplicated code into a method? I unfortunately don't have time at the moment to deal with it.

from react-native-wkwebview.

Done @shirakaba @insraq

from react-native-wkwebview.

Thanks.

from react-native-wkwebview.

@insraq Could yoy please notify me when npm package will be updated?

from react-native-wkwebview.