Add `strpos` scalar string function. about crate HOT 8 CLOSED

can i work on this?

from crate.

Sure, assigned it to you

from crate.

Hello,
Just a small clarification, in postgresql the index starts from 1 strpos('abracadabra', 'abra') -> 0 will be 1 if you run in postgresql db , output will be 0 if there is no match.

so question is do we want to keep 0 indexed or 1 indexed?

from crate.

I'd favor postgres compatibility, but core team should advice

from crate.

I am done with the impl , please let me know if we are to follow postgres compatibility or want to go with 0 index?

from crate.

Let's do it PG compatible, 1 based and 0 for no match.
Thanks!

from crate.

ok

from crate.

This has been closed by #15815
Thx again for the contribution @DHRUV6029 !

from crate.