Review all before blocks - use :all instead of :each when possible about climbalytics HOT 1 CLOSED

I've eliminated all of the before :each hooks that were setting up roles by using a before :suite hook for this. For this to work, I had to make sure that the roles were defined after database_cleaner truncated all existing table in the before :suite hook in rails_helper.rb (I just called define_roles below their call to truncation in there). Additionally, when truncation is used for the capybara javascript examples, it needs to be set up to not truncate the roles table. So here are the important changes:

# rails_helper.rb
...
config.before(:suite) do
  ...
  DatabaseCleaner.clean_with(:truncation) # this line truncates all tables before the test suite runs
  define_roles(:setter,:athlete) # make sure this table is created after line above runs
end
config.before(:each) do
  ...
  DatabaseCleaner.strategy = :truncation, {except: %w[roles]}
end
...

Some people might argue that it is bad to have any data setup for the entire test suite like this. I don't fully understand their argument, so I might change my mind about this later, but for now I think it is okay because when I test the actual role model itself, I don't use the :athlete and :setter roles, I use dummy roles that have no special meaning in my application (e.g. :some_role).

Also, I've left all hooks that set up stubs/mocks, and hooks that run http requests. I think the stubs and mocks can't be setup in before :all hooks. For the before hooks that run http requests, I think they are better as shared contexts, but I need to read more about that.

from climbalytics.