Replacing PropertyHelper about crawljax HOT 8 CLOSED

From [email protected] on February 01, 2010 14:05:34
note: the getConfig method, should return a CrawljaxConfigurationReader object, so that
it ONLY contains get methods

from crawljax.

From frankgroeneveld on February 01, 2010 14:12:45
I just found out my solution still has the same problem as the propertyhelper. For
example, in a testcase it is possible to use CrawljaxController.getConfig() without
constructing the CrawljaxController and thus reading a configuration that was set by
a test that was run previously.

from crawljax.

From [email protected] on February 02, 2010 19:56:47
My suggestion is to make the CrawljaxConfiguration object a normal instance variable
and provide a getter (which returns a CrawljaxConfigurationReader).

We should try to remove all the static references to the PropertyHelper for getting
parameter values and instead pass them as method parameters.

This way, the controller (or the crawler) can read the property values and pass them
to the underlying classes and their methods.

from crawljax.

From [email protected] on February 05, 2010 18:55:18
All the static references to the ProperyHelper have been refactored. All the
properties are now passed as method parameters.

The CrawljaxConfiguration object in the controller has become the main API for
setting(/getting) properties.

from crawljax.

From [email protected] on February 05, 2010 19:05:27
CrawljaxConfiguration should never be used, only for setting
CrawljaxConfigurationReader, so CrawlSession should only have read-access, thus a
CrawljaxConfigurationReader object

from crawljax.

From [email protected] on February 10, 2010 15:24:39
Changed CrawljaxConfiguration to CrawljaxConfigurationReader in the CrawlSession,
code changed in r233.

from crawljax.

From frankgroeneveld on February 23, 2010 10:33:11
What is the status of this? Can PropertyHelper be removed?

from crawljax.

From [email protected] on February 23, 2010 18:47:52
There are still two places where PropertyHepler is being used: HibernateUtil and
CrawljaxConfigurationReader

The second one requires some serious refactoring (parseTagElement).

from crawljax.