Giter VIP home page Giter VIP logo

Comments (6)

create3000 avatar create3000 commented on July 22, 2024

I would add these lines to appendInlineChildElement:

		switch (node .checkLoadState ())
		{
			case X3DConstants .COMPLETE_STATE:
			{
				const event = new CustomEvent ("load",
				{
					detail: { node: node ? node .valueOf () : null },
				});

				element .dispatchEvent (event);
				break;
			}
			case X3DConstants .FAILED_STATE:
			{
				const event = new CustomEvent ("error",
				{
					detail: { node: node ? node .valueOf () : null },
				});

				element .dispatchEvent (event);
				break;
			}
		}

Would use load and error to be similar to <image>. This should not collide with the load field, because one would use onload attribute with code.

from x_ite.

create3000 avatar create3000 commented on July 22, 2024

Added documentation:

https://create3000.github.io/x_ite/dom-integration#events-of-inline-element

from x_ite.

andreasplesch avatar andreasplesch commented on July 22, 2024

super.

from x_ite.

andreasplesch avatar andreasplesch commented on July 22, 2024

The 'load' event may be dispatched too early. I think it should be dispatched only after an Inline is completely loaded, eg. after all internal resources, including all internal inlines, are loaded.

https://raw.githack.com/andreasplesch/Library/0b3898b568d1fbaf71a59f74f7a27cdc10685a95/Tests/Browser/DOMIntegration/in_reflection/dom_inlineReflection.xhtml

has two inlines, which have inlines themselves.

After both inlines have fired 'load', a function tries to access DOM elements from the innermost inlines but fails because the DOM elements are not available.

I can put together a simpler example as well.

from x_ite.

create3000 avatar create3000 commented on July 22, 2024

Good idea, makes life much more easier. Ready to be tested.

https://raw.githack.com/andreasplesch/Library/0b3898b568d1fbaf71a59f74f7a27cdc10685a95/Tests/Browser/DOMIntegration/in_reflection/dom_inlineReflection.xhtml

from x_ite.

andreasplesch avatar andreasplesch commented on July 22, 2024

Looks good !

from x_ite.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.