Comments (4)
This may be an issue with node -- It appears that the fs.stat
callback is getting triggered _before_ the next.parallel() -> process.nextTick() --> check
, at least in this specific case (FYI, for some reason I can only get this to happen on the step/test
directory. I noticed it because that was a sub-directory of something I was scanning).
from step.
... that's exactly what is happening
var fs = require('fs');
fs.stat( '.', function(){ console.log( 'Stat is done' ); });
for( var i=0; i<100000; i++);
process.nextTick( function(){ console.log( 'Next Tick' ); } );
Stat is done
shows up first... similarly, the check()
pushed to nextTick is getting triggered late and causing a double-execution of next.apply(...)
. Step is in a race condition with the file-system here :)
from step.
I think that this is not a problem of Node.
check()
is called more one times than the size of the group.
Probably, at the last twice, pending
is 0
.
Therefore localCallback()
may be called twice.
I think that it needs guard.
workaround:
@@ -95,6 +95,7 @@ function Step() {
function check() {
if (pending === 0) {
+ --pending;
// When group is done, call the callback
localCallback(error, result);
}
from step.
I don't remember if this was fixed? If this is still an issue please re-open. Also see #24
from step.
Related Issues (20)
- Problem if the first argument of a callback is not error HOT 2
- problem in 'throw arguments[0]' HOT 1
- A way to step back to previous HOT 1
- Can I preserve a callback across multiple steps? HOT 2
- Step is broken for use with Express.js! HOT 1
- Consider API for next major version of Step HOT 5
- Cancel a Step Sequence HOT 1
- Race condition in handling of group()-generated callbacks HOT 4
- Broken code in README (node v0.6.12)
- Missing instrunctions on how to run the tests HOT 1
- step ignores wrong javascript code silently HOT 5
- skipping steps HOT 2
- Please throw actual Errors, not strings HOT 2
- process.nextTick(check) in next.group could cause a bug of race condition HOT 1
- step is just no value, it's just a trick HOT 3
- Remove nextTick check for groups. HOT 3
- Change log HOT 4
- Please release 1.0.0 to npm HOT 2
- Returning multiple parameters in a callback that has been grouped HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from step.