Giter VIP home page Giter VIP logo

Comments (4)

possumbilities avatar possumbilities commented on August 25, 2024 1

@CRortyDG In principle I like your suggestion that it should be in the natural HTML <footer> element, but unfortunately there is no guarantee that any theme will have that element. There are still sites and themes that utilize <div> elements for nearly everything so I don't know of a way that we could safely make that route work.

As for you alternate fix, is that something you intend to submit as a Pull Request?

from wp-plugin-creativecommons.

CRortyDG avatar CRortyDG commented on August 25, 2024

I think a better solution would be adding the CC footer element to the natural HTML <footer>\ element to match with site styles, but here is a possible fix that uses the same math as the default footer.

CC-Footer

from wp-plugin-creativecommons.

CRortyDG avatar CRortyDG commented on August 25, 2024

Understandable it cannot be added to the <footer> element!

I would like to submit a Pull Request! I have yet to do this and was only just getting started in open source with a problem I understood. I will have to read more about submitting pull requests to ensure I do it correctly before I do this though.

As for my solution... Thinking about the problem on a wider scale, I am not sure the chosen variable will work, and it will instead need to be defined differently. That variable is defined through the Twenty Twenty-One theme, but not on other themes (specifically not Twenty Twenty-Two in an additional test.)

Do you have any thoughts on a better variable to use in place of --global--spacing-horizontal @possumbilities? Testing 5% seems to work well on multiple screens... I will read more about submitting Pull Requests and better test a solution!

from wp-plugin-creativecommons.

abuansarpatowary avatar abuansarpatowary commented on August 25, 2024

@possumbilities, @TimidRobot Please take a look at this PR #224 and let me know if any enhancements are needed.

from wp-plugin-creativecommons.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.