Comments (4)
How about adding this to Cargo.toml
?
[features]
default = ["vendored"]
vendored = ["git2/vendored-libgit2", "git2/vendored-openssl"]
Then it should work out of the box and advanced users wishing to dynamically link can still turn them on.
Also if crev is doing only basic git operations maybe it wouldn't be hard to rewrite them in Rust. I've seen a project that can already clone git repos (very fast) so maybe build it on top of that. Or maybe even just run git executable - slower but may work well enough?
from cargo-crev.
I'm quite busy at the moment, but in about one week from now I should get some more free time. I'll be happy to give it a shot then!
Edit: Oh, and thank you for getting back to me so quickly!
from cargo-crev.
I apologize in case this issue is completely uncalled for or has already been discussed. I don't currently have the time to do more research, but I have had this experience a couple of times already, and I didn't want to just ignore it again.
No worries. I know it's a pain.
OpenSSL is a PITA. I wish we could not have to use it, but AFAIK libgit2
can't do rust-tls
https://github.com/rust-lang/git2-rs/blob/3e0a6134634f7b5129b6dfeeb0db97ccc9510866/libgit2-sys/Cargo.toml#L33
Provide the Windows binaries as zip files
Noted. I think this shouldn't be too hard to fix.
Line 52 in f44aed1
Maybe you want to give it a try?
from cargo-crev.
Well, I downloaded 7zip in order to experiment with this. Following this description of the command line interface, I suppose the command should just be
7z a -tzip "${NAME}.zip" "${NAME}"
I think there's something wrong with my 7zip setup, though, because I get an error about an "Unsupported archive type" no matter which archive type I specify here. If I just do 7z a test.zip example.txt
, I do get a zip file out, but only 7zip can unzip it again. Windows complains that the archive is broken ยฏ\_(ใ)_/ยฏ
. Therefore, I'm not sure how to test this further.
Edit:
Alright, I managed to fix my 7zip installation. With that, I was able to unpack the .tar.gz
file.
I then used 7z a -tzip "${NAME}.zip" "${NAME}"
with the unpacked file to test this command, and then I unzipped the resulting zip archive with the native Windows unzipping tool for a sanity check. Everything works as expected :)
Should I make a pull request to add this? If so, do you still want to keep the tar.gz
version for Windows as well, or should it be replaced with just the ยด.zip` version?
from cargo-crev.
Related Issues (20)
- CI: AppVeyor builds using Rust 1.58.0 are broken
- Add exponenetial backoff for fetching from repos that fail HOT 2
- cargo-crev repo's nix shell fails with "missing liconv" HOT 5
- Maintain reasonable MSRV so that this has chance of being packaged in distros HOT 2
- `--no-dev-dependencies` flag is not honoured HOT 5
- Bootstrapping
- Release GPG-signed binary HOT 2
- Website's TLS certificate has expired on 2023-03-02 HOT 3
- `No such file or directory` when accessing non existent `ids` directory HOT 3
- cargo-crev panics when trying to review a crate HOT 1
- cargo-vet interoperability? HOT 1
- "Could not find requested crate" unless I revert to the git index HOT 7
- Do we need the `cargo` dependency? HOT 1
- Any show command in cargo crev crev verify does not work expect --show-all
- Outdated Rust in nix HOT 2
- 0.25.5 build failure HOT 4
- index-guix not in repository
- Fails to push main branch after following instruction in quick setup guide HOT 1
- Bug: "the lock file needs to be updated" HOT 1
- Panic in `cargo crev verify --show-all`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cargo-crev.