Comments (3)
subes
commented on May 27, 2024
Here are my proposed methods for this:
public TableIterator<H, R, V> rangeReverse(final H hashKey) {
final DBIterator iterator = db.iterator();
final byte[] keyBytesFrom = Util.combine(hashKeySerde, rangeKeySerde, hashKey, null);
iterator.seek(keyBytesFrom);
Entry<byte[], byte[]> last = null;
while (iterator.hasNext()
&& Util.compareKeys(hashKeyComparator, null, keyBytesFrom, iterator.peekNext().getKey()) == 0) {
last = iterator.next();
}
//if there is no last one, there is nothing at all in the table
if (last == null) {
return new TableIterator<H, R, V>() {
@Override
public boolean hasNext() {
return false;
}
@Override
public TableRow<H, R, V> next() {
throw new NoSuchElementException();
}
@Override
public void remove() {
throw new NoSuchElementException();
}
@Override
public void close() {}
};
}
//since last has been found, seek again for that one
iterator.seek(last.getKey());
return new TableIterator<H, R, V>() {
private boolean fixFirst = true;;
@Override
public boolean hasNext() {
if (useFixFirst()) {
return true;
}
return iterator.hasPrev()
&& Util.compareKeys(hashKeyComparator, null, keyBytesFrom, iterator.peekPrev().getKey()) == 0;
}
public boolean useFixFirst() {
if (fixFirst && iterator.hasNext()) {
fixFirst = false;
final Entry<byte[], byte[]> peekNext = iterator.peekNext();
if (peekNext != null) {
if (Util.compareKeys(hashKeyComparator, null, keyBytesFrom, peekNext.getKey()) == 0) {
return true;
} else {
fixFirst = false;
}
}
}
return false;
}
@Override
public TableRow<H, R, V> next() {
if (useFixFirst()) {
return new RawTableRow<H, R, V>(iterator.peekNext(), hashKeySerde, rangeKeySerde, valueSerde);
}
return new RawTableRow<H, R, V>(iterator.prev(), hashKeySerde, rangeKeySerde, valueSerde);
}
@Override
public void remove() {
if (useFixFirst()) {
throw new UnsupportedOperationException("Not possible on first result for now...");
}
iterator.remove();
}
@Override
public void close() {
try {
iterator.close();
} catch (final Exception e) {
throw new DbException(e);
}
}
};
}
public TableIterator<H, R, V> rangeReverse(final H hashKey, final R fromRangeKey) {
final DBIterator iterator = db.iterator();
final byte[] keyBytesFrom = Util.combine(hashKeySerde, rangeKeySerde, hashKey, fromRangeKey);
iterator.seek(keyBytesFrom);
return new TableIterator<H, R, V>() {
private boolean fixFirst = true;
@Override
public boolean hasNext() {
if (useFixFirst()) {
return true;
}
return iterator.hasPrev()
&& Util.compareKeys(hashKeyComparator, null, keyBytesFrom, iterator.peekPrev().getKey()) == 0;
}
public boolean useFixFirst() {
if (fixFirst && iterator.hasNext()) {
fixFirst = false;
final Entry<byte[], byte[]> peekNext = iterator.peekNext();
if (peekNext != null) {
if (Util.compareKeys(hashKeyComparator, null, keyBytesFrom, peekNext.getKey()) == 0) {
return true;
} else {
fixFirst = false;
}
}
}
return false;
}
@Override
public TableRow<H, R, V> next() {
if (useFixFirst()) {
return new RawTableRow<H, R, V>(iterator.peekNext(), hashKeySerde, rangeKeySerde, valueSerde);
}
return new RawTableRow<H, R, V>(iterator.prev(), hashKeySerde, rangeKeySerde, valueSerde);
}
@Override
public void remove() {
if (useFixFirst()) {
throw new UnsupportedOperationException("Not possible on first result for now...");
}
iterator.remove();
}
@Override
public void close() {
try {
iterator.close();
} catch (final Exception e) {
throw new DbException(e);
}
}
};
}
public TableIterator<H, R, V> rangeReverse(final H hashKey, final R fromRangeKey, final R toRangeKey) {
final DBIterator iterator = db.iterator();
final byte[] keyBytesFrom = Util.combine(hashKeySerde, rangeKeySerde, hashKey, fromRangeKey);
final byte[] keyBytesTo = Util.combine(hashKeySerde, rangeKeySerde, hashKey, toRangeKey);
iterator.seek(keyBytesFrom);
return new TableIterator<H, R, V>() {
private boolean fixFirst = true;
@Override
public boolean hasNext() {
if (useFixFirst()) {
return true;
}
return iterator.hasPrev()
&& Util.compareKeys(hashKeyComparator, rangeKeyComparator, keyBytesTo, iterator.peekPrev()
.getKey()) < 0;
}
public boolean useFixFirst() {
if (fixFirst && iterator.hasNext()) {
fixFirst = false;
final Entry<byte[], byte[]> peekNext = iterator.peekNext();
if (peekNext != null) {
if (Util.compareKeys(hashKeyComparator, rangeKeyComparator, keyBytesTo, peekNext.getKey()) <= 0) {
return true;
} else {
fixFirst = false;
}
}
}
return false;
}
@Override
public TableRow<H, R, V> next() {
if (useFixFirst()) {
return new RawTableRow<H, R, V>(iterator.peekNext(), hashKeySerde, rangeKeySerde, valueSerde);
}
return new RawTableRow<H, R, V>(iterator.prev(), hashKeySerde, rangeKeySerde, valueSerde);
}
@Override
public void remove() {
if (useFixFirst()) {
throw new UnsupportedOperationException("Not possible on first result for now...");
}
iterator.remove();
}
@Override
public void close() {
try {
iterator.close();
} catch (final Exception e) {
throw new DbException(e);
}
}
};
}
They are tested to work fine for me. I don't use remove, so I've just disabled it for the useFixFirst special case for the result to spare me the effort of finding out how to do that properly.
UseFixFirst works as follows:
in a set of 1,2,3 and a query starting from 3. Without the useFixFirst workaround this would iterate 2,1. With useFixFirst workaround this correctly iterates 3,2,1.
from ezdb.
criccomini
commented on May 27, 2024
Hey Subes,
This is great. The only recommendation that I have is making the useFixFirst method private. It mutates state, and shouldn't allow others to call it.
If you want to patch this, and send a pull request over, I'll merge it in. With the patch, please include:
- Tests
- Javadocs for the UseFixFirst function.
Cheers,
Chris
from ezdb.
subes
commented on May 27, 2024
Since the code has been migrated, this issue can be closed.
from ezdb.
Related Issues (5)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ezdb.