1.14.5 Native patching behavior change - XR desired state dropped if a resource won't get all required schema values about crossplane HOT 9 OPEN

@xoanmi just like in "test-comp-one" composition above, you need to add

policy:
  fromFieldPath: Required

to any patches of XRs/MRs in composition that patch in the value required by schema.

With an example of VPC Managed Resource from aws provider you would need that policy for a patch responsible for value of spec.forProvider.cidrBlock

from crossplane.

We have the same problem. We have not been able to work around it. Did you do it @y4ri ?

from crossplane.

@xoanmi just like in "test-comp-one" composition above, you need to add

policy:
  fromFieldPath: Required

to any patches of XRs/MRs in composition that patch in the value required by schema.

With an example of VPC Managed Resource from aws provider you would need that policy for a patch responsible for value of spec.forProvider.cidrBlock

Thanks! I misread your previous message. We have applied the workaround and it works! 🚀

from crossplane.

@negz, pretty sure, the example here is extremely complicated, but the core issue is the same, patches to the xr not being executed because of a failure applying a composed resource.

from crossplane.

@y4ri Do you see any errors or warnings when this is happening? If so, could you let us know what they are.

from crossplane.

1.14.5 - On XR level just a bunch of

Warning  ComposeResources         13s                defined/compositeresourcedefinition.apiextensions.crossplane.io  cannot compose resources: cannot apply composed resource: cannot create object: XDummy.example.org "test-qksw8-dlpcx" is invalid: spec.exampleField: Required value

ending with

Warning  ComposeResources         9s (x14 over 13s)  defined/compositeresourcedefinition.apiextensions.crossplane.io  (combined from similar events): cannot compose resources: cannot apply composed resource: cannot create object: XDummy.example.org "test-qksw8-m96gr" is invalid: spec.exampleField: Required value

On 1.13.2 I only get 1 warrning:

Warning  ComposeResources         21s                defined/compositeresourcedefinition.apiextensions.crossplane.io  composed resource "second-xdummy": cannot use dry-run create to name composed resource: XDummy.example.org "test-jf7q7-5nswr" is invalid: spec.exampleField: Required value

from crossplane.

I think this is because we used to dry run here to get the generated name and the code below still assumes the resources to be valid, which in case of a missing required field is not the case anymore and therefore we exit erroring here.
This applies to all 1.14 releases and to v1.15.0-rc.1 too.

from crossplane.

I think this is a duplicate of #5114

from crossplane.

I think this is a duplicate of #5114

@phisco How sure are you? At a glance it sounds like the described behaviour is different.

from crossplane.