Giter VIP home page Giter VIP logo

Comments (4)

negz avatar negz commented on May 28, 2024 1

We could think of splitting the caching mechanism to its separate command so that one could use its output to feed CRDs to kubectl validate directly instead. IIRC having two separate commands was actually one of the initial proposals 😅

My two cents: crossplane validate feels like a better UX to me than crossplane fetch && kubectl validate.

from crossplane.

phisco avatar phisco commented on May 28, 2024

We should also add support for missing types of schema errors, see discussion here. To be understood how much will be left after the PR from @ezgidemirel to add x-kubernetes-validations.

from crossplane.

negz avatar negz commented on May 28, 2024

I learned today that kubectl validate is a thing. Apparently it does a lot of what our validate command does, and is designed to be used a library that other tools can depend on. We might consider using it.

from crossplane.

phisco avatar phisco commented on May 28, 2024

Thanks @negz for pointing that out, definitely interesting, I gave it a quick shot and although it looks like we could plug it pretty easily, just keeping our schema caching logic and leaving everything else to their implementation, potentially with a few added benefits such as the ability to use CRDs from a running Cluster. There is still a risk due to the overlapping dependencies, e.g. right now we would have to downgrade a few things to be able to import sigs.k8s.io/kubectl-validate and I couldn't easily make it build. It could be worth rethinking about this once/if we move the crossplane cli to its own repo as per #4850.

We could think of splitting the caching mechanism to its separate command so that one could use its output to feed CRDs to kubectl validate directly instead. IIRC having two separate commands was actually one of the initial proposals 😅

from crossplane.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.