Giter VIP home page Giter VIP logo

Comments (7)

zzxwill avatar zzxwill commented on August 20, 2024

I think I also need to post this feature request to Knative community : )

from oam-kubernetes-runtime.

zzxwill avatar zzxwill commented on August 20, 2024

As Knative Configuration needs container port name to be one of "http1" or "h2c" (if supported). Defaults to "http1"., so the first example should be ignored.
https://github.com/knative/docs/blob/master/docs/serving/spec/knative-api-specification-1.0.md#containerport

from oam-kubernetes-runtime.

wonderflow avatar wonderflow commented on August 20, 2024

I don't think this is an issue. As we use Knative workload here, we should follow roles of what knative has.

from oam-kubernetes-runtime.

zzxwill avatar zzxwill commented on August 20, 2024

@wonderflow You are right. But for spec.parameters, it will be the problem.

from oam-kubernetes-runtime.

ryanzhang-oss avatar ryanzhang-oss commented on August 20, 2024

I don't know what the KNative webhook logic has anything to do with an OAM component's spec.parameter?

from oam-kubernetes-runtime.

wonderflow avatar wonderflow commented on August 20, 2024

I don't know what the KNative webhook logic has anything to do with an OAM component's spec.parameter?

Neither do I.

And I don't think we need to use parameter in Knative demo. We should avoid use parameter as it will confuse with component versioning mechanism.

from oam-kubernetes-runtime.

zzxwill avatar zzxwill commented on August 20, 2024

As parameter is deprecated, this won't block Knative webhook from blocking the request. Close the issue.

from oam-kubernetes-runtime.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.